Add support for TaskDelete event on exec in RuntimeV2

jterry75 · jterry75 · commit a4f7b3758e7c · 2019-02-12T15:50:21.000-08:00
Signed-off-by: Justin Terry (VM) &lt;juterry@microsoft.com&gt;
diff --git a/api/events/task.pb.go b/api/events/task.pb.go
diff --git a/api/events/task.proto b/api/events/task.proto
@@ -29,6 +29,9 @@ message TaskDelete {
 	uint32 pid = 2;
 	uint32 exit_status = 3;
 	google.protobuf.Timestamp exited_at = 4 [(gogoproto.stdtime) = true, (gogoproto.nullable) = false];
+	// id is the specific exec. By default if omitted will be `""` thus matches
+	// the init exec of the task matching `container_id`.
+	string id = 5;
 }
 
 message TaskIO {
diff --git a/api/next.pb.txt b/api/next.pb.txt
@@ -627,6 +627,13 @@ file {
       }
       json_name: "exitedAt"
     }
+    field {
+      name: "id"
+      number: 5
+      label: LABEL_OPTIONAL
+      type: TYPE_STRING
+      json_name: "id"
+    }
   }
   message_type {
     name: "TaskIO"
diff --git a/runtime/v2/README.md b/runtime/v2/README.md
@@ -169,7 +169,9 @@ The Runtime v2 supports an async event model. In order for the an upstream calle
 | Topic | Compliance | Description |
 | ----- | ---------- | ----------- |
 | `runtime.TaskExecAddedEventTopic`   | MUST (follow `TaskCreateEventTopic` )     | When an exec is successfully added |
-| `runtime.TaskExecStartedEventTopic` | MUST (follow `TaskExecStartedEventTopic`) | When an exec is successfully started |
+| `runtime.TaskExecStartedEventTopic` | MUST (follow `TaskExecAddedEventTopic`)   | When an exec is successfully started |
+| `runtime.TaskExitEventTopic`        | MUST (follow `TaskExecStartedEventTopic`) | When an exec (other than the init exec) exits expected or unexpected |
+| `runtime.TaskDeleteEventTopic`      | SHOULD (follow `TaskExitEventTopic` or `TaskExecAddedEventTopic` if never started) | When an exec is removed from a shim |
 
 ### Other
 

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,9 @@ message TaskDelete {`
`29`	`29`	`uint32 pid = 2;`
`30`	`30`	`uint32 exit_status = 3;`
`31`	`31`	`google.protobuf.Timestamp exited_at = 4 [(gogoproto.stdtime) = true, (gogoproto.nullable) = false];`
	`32`	+ // id is the specific exec. By default if omitted will be `""` thus matches
	`33`	+ // the init exec of the task matching `container_id`.
	`34`	`+ string id = 5;`
`32`	`35`	`}`
`33`	`36`
`34`	`37`	`message TaskIO {`
Original file line number	Diff line number	Diff line change
`@@ -627,6 +627,13 @@ file {`
`627`	`627`	`}`
`628`	`628`	`json_name: "exitedAt"`
`629`	`629`	`}`
	`630`	`+ field {`
	`631`	`+ name: "id"`
	`632`	`+ number: 5`
	`633`	`+ label: LABEL_OPTIONAL`
	`634`	`+ type: TYPE_STRING`
	`635`	`+ json_name: "id"`
	`636`	`+ }`
`630`	`637`	`}`
`631`	`638`	`message_type {`
`632`	`639`	`name: "TaskIO"`