Skip to content

Commit 88de651

Browse files
committed
Don't build a second copy of containerd-shim-runhcs-v1.exe
`make binaries` already builds containerd-shim-runhcs-v1.exe next to containerd.exe, so there's no need to spend time checking out and building it again. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
1 parent 8047eb2 commit 88de651

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -254,11 +254,6 @@ jobs:
254254
with:
255255
path: src/github.com/containerd/containerd
256256

257-
- uses: actions/checkout@v2
258-
with:
259-
repository: Microsoft/hcsshim
260-
path: src/github.com/Microsoft/hcsshim
261-
262257
- uses: actions/checkout@v2
263258
with:
264259
repository: kubernetes-sigs/cri-tools
@@ -279,12 +274,6 @@ jobs:
279274
run: |
280275
set -o xtrace
281276
mingw32-make.exe binaries
282-
bindir="$(pwd)"
283-
SHIM_COMMIT=$(grep 'Microsoft/hcsshim ' go.mod | awk '{print $2}')
284-
cd ../../Microsoft/hcsshim
285-
git fetch --tags origin "${SHIM_COMMIT}"
286-
git checkout "${SHIM_COMMIT}"
287-
GO111MODULE=on go build -mod=vendor -o "${bindir}/integration/client/containerd-shim-runhcs-v1.exe" ./cmd/containerd-shim-runhcs-v1
288277
cd ../../kubernetes-sigs/cri-tools
289278
make critest
290279

.github/workflows/windows-periodic.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,13 +150,6 @@ jobs:
150150
run: |
151151
ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "git clone http://github.com/containerd/containerd c:\\containerd "
152152
ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "cd c:\containerd ; make binaries"
153-
ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "git clone http://github.com/Microsoft/hcsshim c:\containerd\hcsshim "
154-
155-
# Get shim commit from containerd local repo
156-
SHIM_COMMIT=$(grep 'Microsoft/hcsshim' go.mod | awk '{ print $2 }');
157-
158-
ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "cd c:\containerd\hcsshim; git fetch --tags origin $SHIM_COMMIT ; \
159-
git checkout $SHIM_COMMIT ; go build -mod=vendor -o ${{ env.REMOTE_VM_BIN_PATH }}\containerd-shim-runhcs-v1.exe .\cmd\containerd-shim-runhcs-v1"
160153
161154
- name: RunIntegrationTests
162155
run: |

0 commit comments

Comments
 (0)