client: surface a connection error more clearly

Kazuyoshi Kato · Kazuyoshi Kato · commit 73d28ddeb27a · 2021-07-02T14:56:04.000-07:00
gRPC-Go recently added grpc.WithReturnConnectionError() which improves the situation of containerd#2576. Permission errors: % ./bin/ctr t ls ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied" % Non-existent sockets: % ./bin/ctr -a notfound t ls ctr: failed to dial "notfound": context deadline exceeded: connection error: desc = "transport: error while dialing: dial unix://notfound: timeout" % Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
diff --git a/client.go b/client.go
@@ -123,6 +123,7 @@ func New(address string, opts ...ClientOpt) (*Client, error) {
 			grpc.FailOnNonTempDialError(true),
 			grpc.WithConnectParams(connParams),
 			grpc.WithContextDialer(dialer.ContextDialer),
+			grpc.WithReturnConnectionError(),
 
 			// TODO(stevvooe): We may need to allow configuration of this on the client.
 			grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(defaults.DefaultMaxRecvMsgSize)),
