Use constant to replace integer literal

HuKeping · HuKeping · commit 10800f62ae8b · 2016-04-26T06:02:49.000-04:00
Signed-off-by: Hu Keping &lt;hukeping@huawei.com&gt;
diff --git a/ctr/checkpoint.go b/ctr/checkpoint.go
@@ -43,7 +43,7 @@ func listCheckpoints(context *cli.Context) {
 		id = context.Args().First()
 	)
 	if id == "" {
-		fatal("container id cannot be empty", 1)
+		fatal("container id cannot be empty", ExitStatusMissingArg)
 	}
 	resp, err := c.ListCheckpoint(netcontext.Background(), &types.ListCheckpointRequest{
 		Id: id,
@@ -88,10 +88,10 @@ var createCheckpointCommand = cli.Command{
 			name        = context.Args().Get(1)
 		)
 		if containerID == "" {
-			fatal("container id at cannot be empty", 1)
+			fatal("container id at cannot be empty", ExitStatusMissingArg)
 		}
 		if name == "" {
-			fatal("checkpoint name cannot be empty", 1)
+			fatal("checkpoint name cannot be empty", ExitStatusMissingArg)
 		}
 		c := getClient(context)
 		if _, err := c.CreateCheckpoint(netcontext.Background(), &types.CreateCheckpointRequest{
@@ -118,10 +118,10 @@ var deleteCheckpointCommand = cli.Command{
 			name        = context.Args().Get(1)
 		)
 		if containerID == "" {
-			fatal("container id at cannot be empty", 1)
+			fatal("container id at cannot be empty", ExitStatusMissingArg)
 		}
 		if name == "" {
-			fatal("checkpoint name cannot be empty", 1)
+			fatal("checkpoint name cannot be empty", ExitStatusMissingArg)
 		}
 		c := getClient(context)
 		if _, err := c.DeleteCheckpoint(netcontext.Background(), &types.DeleteCheckpointRequest{
diff --git a/ctr/container.go b/ctr/container.go
@@ -146,10 +146,10 @@ var startCommand = cli.Command{
 			path = context.Args().Get(1)
 		)
 		if path == "" {
-			fatal("bundle path cannot be empty", 1)
+			fatal("bundle path cannot be empty", ExitStatusMissingArg)
 		}
 		if id == "" {
-			fatal("container id cannot be empty", 1)
+			fatal("container id cannot be empty", ExitStatusMissingArg)
 		}
 		bpath, err := filepath.Abs(path)
 		if err != nil {
@@ -336,7 +336,7 @@ var pauseCommand = cli.Command{
 	Action: func(context *cli.Context) {
 		id := context.Args().First()
 		if id == "" {
-			fatal("container id cannot be empty", 1)
+			fatal("container id cannot be empty", ExitStatusMissingArg)
 		}
 		c := getClient(context)
 		_, err := c.UpdateContainer(netcontext.Background(), &types.UpdateContainerRequest{
@@ -356,7 +356,7 @@ var resumeCommand = cli.Command{
 	Action: func(context *cli.Context) {
 		id := context.Args().First()
 		if id == "" {
-			fatal("container id cannot be empty", 1)
+			fatal("container id cannot be empty", ExitStatusMissingArg)
 		}
 		c := getClient(context)
 		_, err := c.UpdateContainer(netcontext.Background(), &types.UpdateContainerRequest{
@@ -388,7 +388,7 @@ var killCommand = cli.Command{
 	Action: func(context *cli.Context) {
 		id := context.Args().First()
 		if id == "" {
-			fatal("container id cannot be empty", 1)
+			fatal("container id cannot be empty", ExitStatusMissingArg)
 		}
 		c := getClient(context)
 		if _, err := c.Signal(netcontext.Background(), &types.SignalRequest{

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func listCheckpoints(context *cli.Context) {`
`43`	`43`	`id = context.Args().First()`
`44`	`44`	`)`
`45`	`45`	`if id == "" {`
`46`		`- fatal("container id cannot be empty", 1)`
	`46`	`+ fatal("container id cannot be empty", ExitStatusMissingArg)`
`47`	`47`	`}`
`48`	`48`	`resp, err := c.ListCheckpoint(netcontext.Background(), &types.ListCheckpointRequest{`
`49`	`49`	`Id: id,`
`@@ -88,10 +88,10 @@ var createCheckpointCommand = cli.Command{`
`88`	`88`	`name = context.Args().Get(1)`
`89`	`89`	`)`
`90`	`90`	`if containerID == "" {`
`91`		`- fatal("container id at cannot be empty", 1)`
	`91`	`+ fatal("container id at cannot be empty", ExitStatusMissingArg)`
`92`	`92`	`}`
`93`	`93`	`if name == "" {`
`94`		`- fatal("checkpoint name cannot be empty", 1)`
	`94`	`+ fatal("checkpoint name cannot be empty", ExitStatusMissingArg)`
`95`	`95`	`}`
`96`	`96`	`c := getClient(context)`
`97`	`97`	`if _, err := c.CreateCheckpoint(netcontext.Background(), &types.CreateCheckpointRequest{`
`@@ -118,10 +118,10 @@ var deleteCheckpointCommand = cli.Command{`
`118`	`118`	`name = context.Args().Get(1)`
`119`	`119`	`)`
`120`	`120`	`if containerID == "" {`
`121`		`- fatal("container id at cannot be empty", 1)`
	`121`	`+ fatal("container id at cannot be empty", ExitStatusMissingArg)`
`122`	`122`	`}`
`123`	`123`	`if name == "" {`
`124`		`- fatal("checkpoint name cannot be empty", 1)`
	`124`	`+ fatal("checkpoint name cannot be empty", ExitStatusMissingArg)`
`125`	`125`	`}`
`126`	`126`	`c := getClient(context)`
`127`	`127`	`if _, err := c.DeleteCheckpoint(netcontext.Background(), &types.DeleteCheckpointRequest{`