fix progress indicator bug

bchuecos · web-flow · commit fc55e01d8639 · 2022-03-05T01:48:11.000Z
diff --git a/pkg/cmd/codespace/ports.go b/pkg/cmd/codespace/ports.go
@@ -309,11 +309,12 @@ func (a *App) UpdatePortVisibility(ctx context.Context, codespaceName string, ar
 		})
 
 		// wait for success or failure
-		if err := g.Wait(); err != nil {
+		err := g.Wait()
+		a.StopProgressIndicator()
+		if err != nil {
 			return err
 		}
 
-		a.StopProgressIndicator()
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -309,11 +309,12 @@ func (a *App) UpdatePortVisibility(ctx context.Context, codespaceName string, ar`
`309`	`309`	`})`
`310`	`310`
`311`	`311`	`// wait for success or failure`
`312`		`- if err := g.Wait(); err != nil {`
	`312`	`+ err := g.Wait()`
	`313`	`+ a.StopProgressIndicator()`
	`314`	`+ if err != nil {`
`313`	`315`	`return err`
`314`	`316`	`}`
`315`	`317`
`316`		`- a.StopProgressIndicator()`
`317`	`318`	`}`
`318`	`319`
`319`	`320`	`return nil`