Fix pasting Personal Access Token to auth login for GHE

mislav · mislav · commit f807795491e9 · 2021-02-23T10:19:11.000+01:00
diff --git a/pkg/cmd/auth/shared/oauth_scopes.go b/pkg/cmd/auth/shared/oauth_scopes.go
@@ -40,7 +40,7 @@ func HasMinimumScopes(httpClient httpClient, hostname, authToken string) error {
 		return err
 	}
 
-	req.Header.Set("Autorization", "token "+authToken)
+	req.Header.Set("Authorization", "token "+authToken)
 
 	res, err := httpClient.Do(req)
 	if err != nil {
diff --git a/pkg/cmd/auth/shared/oauth_scopes_test.go b/pkg/cmd/auth/shared/oauth_scopes_test.go
@@ -52,7 +52,9 @@ func Test_HasMinimumScopes(t *testing.T) {
 			fakehttp := &httpmock.Registry{}
 			defer fakehttp.Verify(t)
 
+			var gotAuthorization string
 			fakehttp.Register(httpmock.REST("GET", ""), func(req *http.Request) (*http.Response, error) {
+				gotAuthorization = req.Header.Get("authorization")
 				return &http.Response{
 					Request:    req,
 					StatusCode: 200,
@@ -70,6 +72,7 @@ func Test_HasMinimumScopes(t *testing.T) {
 			} else {
 				assert.NoError(t, err)
 			}
+			assert.Equal(t, gotAuthorization, "token ATOKEN")
 		})
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func HasMinimumScopes(httpClient httpClient, hostname, authToken string) error {`
`40`	`40`	`return err`
`41`	`41`	`}`
`42`	`42`
`43`		`- req.Header.Set("Autorization", "token "+authToken)`
	`43`	`+ req.Header.Set("Authorization", "token "+authToken)`
`44`	`44`
`45`	`45`	`res, err := httpClient.Do(req)`
`46`	`46`	`if err != nil {`