updates from review

veverkap · web-flow · commit edfaac23dac6 · 2022-03-02T13:17:57.000Z
diff --git a/internal/codespaces/api/api.go b/internal/codespaces/api/api.go
@@ -701,23 +701,13 @@ func (a *API) DeleteCodespace(ctx context.Context, codespaceName string) error {
 }
 
 type EditCodespaceParams struct {
-	DisplayName        string
-	IdleTimeoutMinutes int
-	Machine            string
-}
-
-type editRequest struct {
 	DisplayName        string `json:"display_name,omitempty"`
 	IdleTimeoutMinutes int    `json:"idle_timeout_minutes,omitempty"`
 	Machine            string `json:"machine,omitempty"`
 }
 
 func (a *API) EditCodespace(ctx context.Context, codespaceName string, params *EditCodespaceParams) (*Codespace, error) {
-	requestBody, err := json.Marshal(editRequest{
-		DisplayName:        params.DisplayName,
-		IdleTimeoutMinutes: params.IdleTimeoutMinutes,
-		Machine:            params.Machine,
-	})
+	requestBody, err := json.Marshal(params)
 
 	if err != nil {
 		return nil, fmt.Errorf("error marshaling request: %w", err)
@@ -735,7 +725,7 @@ func (a *API) EditCodespace(ctx context.Context, codespaceName string, params *E
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated {
+	if resp.StatusCode != http.StatusOK {
 		return nil, api.HandleHTTPError(resp)
 	}
 
diff --git a/pkg/cmd/codespace/edit.go b/pkg/cmd/codespace/edit.go
@@ -50,7 +50,7 @@ func (a *App) Edit(ctx context.Context, opts editOptions) error {
 		SKU:           opts.machine,
 	}
 	a.StartProgressIndicatorWithLabel("Editing codespace")
-	codespace, err := a.apiClient.EditCodespace(ctx, userInputs.CodespaceName, &api.EditCodespaceParams{
+	_, err := a.apiClient.EditCodespace(ctx, userInputs.CodespaceName, &api.EditCodespaceParams{
 		DisplayName:        userInputs.DisplayName,
 		IdleTimeoutMinutes: int(userInputs.IdleTimeout.Minutes()),
 		Machine:            userInputs.SKU,
@@ -60,6 +60,5 @@ func (a *App) Edit(ctx context.Context, opts editOptions) error {
 		return fmt.Errorf("error editing codespace: %w", err)
 	}
 
-	fmt.Fprintln(a.io.Out, codespace.DisplayName)
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func (a *App) Edit(ctx context.Context, opts editOptions) error {`
`50`	`50`	`SKU: opts.machine,`
`51`	`51`	`}`
`52`	`52`	`a.StartProgressIndicatorWithLabel("Editing codespace")`
`53`		`- codespace, err := a.apiClient.EditCodespace(ctx, userInputs.CodespaceName, &api.EditCodespaceParams{`
	`53`	`+ _, err := a.apiClient.EditCodespace(ctx, userInputs.CodespaceName, &api.EditCodespaceParams{`
`54`	`54`	`DisplayName: userInputs.DisplayName,`
`55`	`55`	`IdleTimeoutMinutes: int(userInputs.IdleTimeout.Minutes()),`
`56`	`56`	`Machine: userInputs.SKU,`
`@@ -60,6 +60,5 @@ func (a *App) Edit(ctx context.Context, opts editOptions) error {`
`60`	`60`	`return fmt.Errorf("error editing codespace: %w", err)`
`61`	`61`	`}`
`62`	`62`
`63`		`- fmt.Fprintln(a.io.Out, codespace.DisplayName)`
`64`	`63`	`return nil`
`65`	`64`	`}`