track installed tag name

vilmibm · vilmibm · commit e85b0480e908 · 2021-09-20T17:10:18.000-05:00
diff --git a/pkg/cmd/extension/http.go b/pkg/cmd/extension/http.go
@@ -47,6 +47,7 @@ type releaseAsset struct {
 }
 
 type release struct {
+	Tag    string `json:"tag_name"`
 	Assets []releaseAsset
 }
 
diff --git a/pkg/cmd/extension/manager.go b/pkg/cmd/extension/manager.go
@@ -180,12 +180,12 @@ func (m *Manager) InstallLocal(dir string) error {
 	return makeSymlink(dir, targetLink)
 }
 
-type BinManifest struct {
+type binManifest struct {
 	Owner string
 	Name  string
 	Host  string
+	Tag   string
 	// TODO I may end up not using this; just thinking ahead to local installs
-	// TODO track version
 	Path string
 }
 
@@ -248,11 +248,12 @@ func (m *Manager) installBin(client *http.Client, repo ghrepo.Interface) error {
 		return fmt.Errorf("failed to download asset %s: %w", asset.Name, err)
 	}
 
-	manifest := BinManifest{
+	manifest := binManifest{
 		Name:  name,
 		Owner: repo.RepoOwner(),
 		Host:  repo.RepoHost(),
 		Path:  binPath,
+		Tag:   r.Tag,
 	}
 
 	bs, err := yaml.Marshal(manifest)
diff --git a/pkg/cmd/extension/manager_test.go b/pkg/cmd/extension/manager_test.go
@@ -254,6 +254,7 @@ func TestManager_Install_binary(t *testing.T) {
 		httpmock.REST("GET", "api/v3/repos/owner/gh-bin-ext/releases/latest"),
 		httpmock.JSONResponse(
 			release{
+				Tag: "v1.0.1",
 				Assets: []releaseAsset{
 					{
 						Name:   "gh-bin-ext-windows-amd64",
@@ -276,14 +277,15 @@ func TestManager_Install_binary(t *testing.T) {
 	manifest, err := os.ReadFile(filepath.Join(tempDir, "extensions/gh-bin-ext/manifest.yml"))
 	assert.NoError(t, err)
 
-	var bm BinManifest
+	var bm binManifest
 	err = yaml.Unmarshal(manifest, &bm)
 	assert.NoError(t, err)
 
-	assert.Equal(t, BinManifest{
+	assert.Equal(t, binManifest{
 		Name:  "gh-bin-ext",
 		Owner: "owner",
 		Host:  "example.com",
+		Tag:   "v1.0.1",
 		Path:  filepath.Join(tempDir, "extensions/gh-bin-ext/gh-bin-ext"),
 	}, bm)
 

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ type releaseAsset struct {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`type release struct {`
	`50`	+ Tag string `json:"tag_name"`
`50`	`51`	`Assets []releaseAsset`
`51`	`52`	`}`
`52`	`53`
Original file line number	Diff line number	Diff line change
`@@ -180,12 +180,12 @@ func (m *Manager) InstallLocal(dir string) error {`
`180`	`180`	`return makeSymlink(dir, targetLink)`
`181`	`181`	`}`
`182`	`182`
`183`		`-type BinManifest struct {`
	`183`	`+type binManifest struct {`
`184`	`184`	`Owner string`
`185`	`185`	`Name string`
`186`	`186`	`Host string`
	`187`	`+ Tag string`
`187`	`188`	`// TODO I may end up not using this; just thinking ahead to local installs`
`188`		`- // TODO track version`
`189`	`189`	`Path string`
`190`	`190`	`}`
`191`	`191`
`@@ -248,11 +248,12 @@ func (m Manager) installBin(client http.Client, repo ghrepo.Interface) error {`
`248`	`248`	`return fmt.Errorf("failed to download asset %s: %w", asset.Name, err)`
`249`	`249`	`}`
`250`	`250`
`251`		`- manifest := BinManifest{`
	`251`	`+ manifest := binManifest{`
`252`	`252`	`Name: name,`
`253`	`253`	`Owner: repo.RepoOwner(),`
`254`	`254`	`Host: repo.RepoHost(),`
`255`	`255`	`Path: binPath,`
	`256`	`+ Tag: r.Tag,`
`256`	`257`	`}`
`257`	`258`
`258`	`259`	`bs, err := yaml.Marshal(manifest)`