use Command.Hidden

vilmibm · vilmibm · commit e2ef712e4391 · 2020-06-08T12:31:40.000-05:00
diff --git a/cmd/gen-docs/main.go b/cmd/gen-docs/main.go
@@ -19,12 +19,6 @@ func main() {
 	dir := docCmd.StringP("doc-path", "", "", "Path directory where you want generate doc files")
 	help := docCmd.BoolP("help", "h", false, "Help about any command")
 
-	for _, cmd := range command.RootCmd.Commands() {
-		if _, hidden := cmd.Annotations["hidden"]; hidden {
-			command.RootCmd.RemoveCommand(cmd)
-		}
-	}
-
 	if err := docCmd.Parse(os.Args); err != nil {
 		os.Exit(1)
 	}
diff --git a/command/credits.go b/command/credits.go
@@ -49,9 +49,9 @@ var creditsCmd = &cobra.Command{
   gh credits -s         # display a non-animated thank you
   gh credits | cat      # just print the contributors, one per line
 `,
-	Args:        cobra.ExactArgs(0),
-	RunE:        ghCredits,
-	Annotations: map[string]string{"hidden": "true"},
+	Args:   cobra.ExactArgs(0),
+	RunE:   ghCredits,
+	Hidden: true,
 }
 
 func ghCredits(cmd *cobra.Command, _ []string) error {
diff --git a/command/repo.go b/command/repo.go
@@ -100,10 +100,9 @@ $ gh repo credits cool/repo # view credits for cool/repo
 $ gh repo credits -s        # print a non-animated thank you
 $ gh repo credits | cat     # pipe to just print the contributors, one per line
 `,
-	Args: cobra.MaximumNArgs(1),
-	RunE: repoCredits,
-	// NB will actually be hidden once https://github.com/cli/cli/pull/1106 is in
-	Annotations: map[string]string{"hidden": "true"},
+	Args:   cobra.MaximumNArgs(1),
+	RunE:   repoCredits,
+	Hidden: true,
 }
 
 func parseCloneArgs(extraArgs []string) (args []string, target string) {
diff --git a/command/root.go b/command/root.go
@@ -363,10 +363,9 @@ func rootHelpFunc(command *cobra.Command, args []string) {
 			continue
 		}
 		s := "  " + rpad(c.Name()+":", c.NamePadding()) + c.Short
-		_, hidden := c.Annotations["hidden"]
 		if includes(coreCommandNames, c.Name()) {
 			coreCommands = append(coreCommands, s)
-		} else if !hidden {
+		} else if !c.Hidden {
 			additionalCommands = append(additionalCommands, s)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -363,10 +363,9 @@ func rootHelpFunc(command *cobra.Command, args []string) {`
`363`	`363`	`continue`
`364`	`364`	`}`
`365`	`365`	`s := " " + rpad(c.Name()+":", c.NamePadding()) + c.Short`
`366`		`- _, hidden := c.Annotations["hidden"]`
`367`	`366`	`if includes(coreCommandNames, c.Name()) {`
`368`	`367`	`coreCommands = append(coreCommands, s)`
`369`		`- } else if !hidden {`
	`368`	`+ } else if !c.Hidden {`
`370`	`369`	`additionalCommands = append(additionalCommands, s)`
`371`	`370`	`}`
`372`	`371`	`}`