Merge pull request cli#3336 from cli/pr-checks-crash

mislav · web-flow · commit df5883186cb1 · 2021-03-31T20:21:52.000+02:00
Treat unrecognized PR Checks statuses as "pending"
diff --git a/api/queries_pr.go b/api/queries_pr.go
@@ -188,10 +188,8 @@ func (pr *PullRequest) ChecksStatus() (summary PullRequestChecksStatus) {
 			summary.Passing++
 		case "ERROR", "FAILURE", "CANCELLED", "TIMED_OUT", "ACTION_REQUIRED":
 			summary.Failing++
-		case "EXPECTED", "REQUESTED", "QUEUED", "PENDING", "IN_PROGRESS", "STALE":
+		default: // "EXPECTED", "REQUESTED", "WAITING", "QUEUED", "PENDING", "IN_PROGRESS", "STALE"
 			summary.Pending++
-		default:
-			panic(fmt.Errorf("unsupported status: %q", state))
 		}
 		summary.Total++
 	}
diff --git a/pkg/cmd/pr/checks/checks.go b/pkg/cmd/pr/checks/checks.go
@@ -141,13 +141,11 @@ func checksRun(opts *ChecksOptions) error {
 			markColor = cs.Red
 			failing++
 			bucket = "fail"
-		case "EXPECTED", "REQUESTED", "QUEUED", "PENDING", "IN_PROGRESS", "STALE":
+		default: // "EXPECTED", "REQUESTED", "WAITING", "QUEUED", "PENDING", "IN_PROGRESS", "STALE"
 			mark = "-"
 			markColor = cs.Yellow
 			pending++
 			bucket = "pending"
-		default:
-			panic(fmt.Errorf("unsupported status: %q", state))
 		}
 
 		elapsed := ""

Original file line number	Diff line number	Diff line change
`@@ -188,10 +188,8 @@ func (pr *PullRequest) ChecksStatus() (summary PullRequestChecksStatus) {`
`188`	`188`	`summary.Passing++`
`189`	`189`	`case "ERROR", "FAILURE", "CANCELLED", "TIMED_OUT", "ACTION_REQUIRED":`
`190`	`190`	`summary.Failing++`
`191`		`- case "EXPECTED", "REQUESTED", "QUEUED", "PENDING", "IN_PROGRESS", "STALE":`
	`191`	`+ default: // "EXPECTED", "REQUESTED", "WAITING", "QUEUED", "PENDING", "IN_PROGRESS", "STALE"`
`192`	`192`	`summary.Pending++`
`193`		`- default:`
`194`		`- panic(fmt.Errorf("unsupported status: %q", state))`
`195`	`193`	`}`
`196`	`194`	`summary.Total++`
`197`	`195`	`}`