Merge pull request cli#103 from github/fix-EnvironmentNotShutdown

Alan Donovan · web-flow · commit dc40d990960d · 2021-08-31T09:18:45.000-04:00
in Start, ignore HTTP 503 with reason 7 EnvironmentNotShutdown
diff --git a/api/api.go b/api/api.go
@@ -274,11 +274,17 @@ func (a *API) StartCodespace(ctx context.Context, token string, codespace *Codes
 	}
 
 	if resp.StatusCode != http.StatusOK {
-		// Error response is numeric code and/or string message, not JSON.
+		// Error response is typically a numeric code (not an error message, nor JSON).
 		if len(b) > 100 {
 			b = append(b[:97], "..."...)
 		}
-		return fmt.Errorf("failed to start codespace: %s", b)
+
+		if resp.StatusCode == http.StatusServiceUnavailable && strings.TrimSpace(string(b)) == "7" {
+			// HTTP 503 with error code 7 (EnvironmentNotShutdown) is benign.
+			// Ignore it.
+		} else {
+			return fmt.Errorf("failed to start codespace: %s", b)
+		}
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -274,11 +274,17 @@ func (a API) StartCodespace(ctx context.Context, token string, codespace Codes`
`274`	`274`	`}`
`275`	`275`
`276`	`276`	`if resp.StatusCode != http.StatusOK {`
`277`		`- // Error response is numeric code and/or string message, not JSON.`
	`277`	`+ // Error response is typically a numeric code (not an error message, nor JSON).`
`278`	`278`	`if len(b) > 100 {`
`279`	`279`	`b = append(b[:97], "..."...)`
`280`	`280`	`}`
`281`		`- return fmt.Errorf("failed to start codespace: %s", b)`
	`281`	`+`
	`282`	`+ if resp.StatusCode == http.StatusServiceUnavailable && strings.TrimSpace(string(b)) == "7" {`
	`283`	`+ // HTTP 503 with error code 7 (EnvironmentNotShutdown) is benign.`
	`284`	`+ // Ignore it.`
	`285`	`+ } else {`
	`286`	`+ return fmt.Errorf("failed to start codespace: %s", b)`
	`287`	`+ }`
`282`	`288`	`}`
`283`	`289`
`284`	`290`	`return nil`