final changes made

pxrth9 · pxrth9 · commit d378dc84c6fd · 2021-10-21T15:17:15.000-04:00
diff --git a/pkg/cmd/repo/rename/rename.go b/pkg/cmd/repo/rename/rename.go
@@ -26,6 +26,7 @@ type RenameOptions struct {
 	Config          func() (config.Config, error)
 	BaseRepo        func() (ghrepo.Interface, error)
 	Remotes         func() (context.Remotes, error)
+	HasRepoOverride bool
 	newRepoSelector string
 }
 
@@ -40,7 +41,6 @@ func NewCmdRename(f *cmdutil.Factory, runf func(*RenameOptions) error) *cobra.Co
 	opts := &RenameOptions{
 		IO:         f.IOStreams,
 		HttpClient: f.HttpClient,
-		BaseRepo:   f.BaseRepo,
 		Remotes:    f.Remotes,
 		Config:     f.Config,
 	}
@@ -57,8 +57,10 @@ func NewCmdRename(f *cmdutil.Factory, runf func(*RenameOptions) error) *cobra.Co
 		With '-R', and two arguments the given repository is replaced with the new name`),
 		Args: cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
+			opts.BaseRepo = f.BaseRepo
+			opts.HasRepoOverride = cmd.Flags().Changed("repo")
+
 			if len(args) > 0 {
-				opts.BaseRepo = f.BaseRepo
 				opts.newRepoSelector = args[0]
 			} else if !opts.IO.CanPrompt() {
 				return &cmdutil.FlagError{
@@ -87,17 +89,18 @@ func renameRun(opts *RenameOptions) error {
 	var input renameRepo
 	var newRepo ghrepo.Interface
 	var baseRemote *context.Remote
+	remoteUpdateError := false
 	newRepoName := opts.newRepoSelector
 
 	currRepo, err := opts.BaseRepo()
 	if err != nil {
 		return err
 	}
 
-	if opts.newRepoSelector == "" {
+	if newRepoName == "" {
 		err = prompt.SurveyAskOne(
 			&survey.Input{
-				Message: "Rename current repo to: ",
+				Message: fmt.Sprintf("Rename %s to: ", currRepo.RepoOwner()+"/"+currRepo.RepoName()),
 			},
 			&newRepoName,
 		)
@@ -120,39 +123,29 @@ func renameRun(opts *RenameOptions) error {
 		return fmt.Errorf("API called failed: %s, please check your parameters", err)
 	}
 
-	if opts.newRepoSelector == "" {
+	if !opts.HasRepoOverride {
 		cfg, err := opts.Config()
 		if err != nil {
 			return err
 		}
-
-		protocol, err := cfg.Get(currRepo.RepoHost(), "git_protocol")
-		if err != nil {
-			return err
-		}
-
-		remotes, err := opts.Remotes()
-		if err != nil {
-			return err
-		}
-
-		baseRemote, err = remotes.FindByRepo(currRepo.RepoOwner(), currRepo.RepoName())
-		if err != nil {
-			return err
-		}
-
+		
+		protocol, _ := cfg.Get(currRepo.RepoHost(), "git_protocol")
+		remotes, _ := opts.Remotes()
+		baseRemote, _ = remotes.FindByRepo(currRepo.RepoOwner(), currRepo.RepoName())
 		remoteURL := ghrepo.FormatRemoteURL(newRepo, protocol)
 		err = git.UpdateRemoteURL(baseRemote.Name, remoteURL)
 		if err != nil {
-			return err
+			cs := opts.IO.ColorScheme()
+			remoteUpdateError = true
+			fmt.Fprintf(opts.IO.ErrOut, "%s warning: unable to update remote '%s' \n", cs.WarningIcon(), err)
 		}
 	}
 
 	if opts.IO.IsStdoutTTY() {
 		cs := opts.IO.ColorScheme()
 		fmt.Fprintf(opts.IO.Out, "%s Renamed repository %s\n", cs.SuccessIcon(), input.RepoOwner+"/"+input.Name)
-		if opts.newRepoSelector == "" {
-			fmt.Fprintf(opts.IO.Out, "%s Updated the %q remote", cs.SuccessIcon(), baseRemote.Name)
+		if !opts.HasRepoOverride && !remoteUpdateError {
+			fmt.Fprintf(opts.IO.Out, "%s Updated the %q remote \n", cs.SuccessIcon(), baseRemote.Name)
 		}
 	}
 
diff --git a/pkg/cmd/repo/repo.go b/pkg/cmd/repo/repo.go
@@ -37,6 +37,8 @@ func NewCmdRepo(f *cmdutil.Factory) *cobra.Command {
 		},
 	}
 
+	cmdutil.EnableRepoOverride(cmd, f)
+
 	cmd.AddCommand(repoViewCmd.NewCmdView(f, nil))
 	cmd.AddCommand(repoForkCmd.NewCmdFork(f, nil))
 	cmd.AddCommand(repoCloneCmd.NewCmdClone(f, nil))

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ func NewCmdRepo(f cmdutil.Factory) cobra.Command {`
`37`	`37`	`},`
`38`	`38`	`}`
`39`	`39`
	`40`	`+ cmdutil.EnableRepoOverride(cmd, f)`
	`41`	`+`
`40`	`42`	`cmd.AddCommand(repoViewCmd.NewCmdView(f, nil))`
`41`	`43`	`cmd.AddCommand(repoForkCmd.NewCmdFork(f, nil))`
`42`	`44`	`cmd.AddCommand(repoCloneCmd.NewCmdClone(f, nil))`