Rename to mention

eddumelendez · eddumelendez · commit cffd56f71757 · 2020-06-15T16:08:10.000-05:00
diff --git a/api/queries_issue.go b/api/queries_issue.go
@@ -198,7 +198,7 @@ func IssueStatus(client *Client, repo ghrepo.Interface, currentUsername string)
 	return &payload, nil
 }
 
-func IssueList(client *Client, repo ghrepo.Interface, state string, labels []string, assigneeString string, limit int, authorString string, mentionedString string, milestoneString string) (*IssuesAndTotalCount, error) {
+func IssueList(client *Client, repo ghrepo.Interface, state string, labels []string, assigneeString string, limit int, authorString string, mentionString string, milestoneString string) (*IssuesAndTotalCount, error) {
 	var states []string
 	switch state {
 	case "open", "":
@@ -212,10 +212,10 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str
 	}
 
 	query := fragments + `
-	query($owner: String!, $repo: String!, $limit: Int, $endCursor: String, $states: [IssueState!] = OPEN, $labels: [String!], $assignee: String, $author: String, $mentioned: String, $milestone: String) {
+	query($owner: String!, $repo: String!, $limit: Int, $endCursor: String, $states: [IssueState!] = OPEN, $labels: [String!], $assignee: String, $author: String, $mention: String, $milestone: String) {
 		repository(owner: $owner, name: $repo) {
 			hasIssuesEnabled
-			issues(first: $limit, after: $endCursor, orderBy: {field: CREATED_AT, direction: DESC}, states: $states, labels: $labels, filterBy: {assignee: $assignee, createdBy: $author, mentioned: $mentioned, milestone: $milestone}) {
+			issues(first: $limit, after: $endCursor, orderBy: {field: CREATED_AT, direction: DESC}, states: $states, labels: $labels, filterBy: {assignee: $assignee, createdBy: $author, mentioned: $mention, milestone: $milestone}) {
 				totalCount
 				nodes {
 					...issue
@@ -243,8 +243,8 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str
 	if authorString != "" {
 		variables["author"] = authorString
 	}
-	if mentionedString != "" {
-		variables["mentioned"] = mentionedString
+	if mentionString != "" {
+		variables["mention"] = mentionString
 	}
 	if milestoneString != "" {
 		variables["milestone"] = milestoneString
diff --git a/command/issue.go b/command/issue.go
@@ -41,7 +41,7 @@ func init() {
 	issueListCmd.Flags().StringP("state", "s", "open", "Filter by state: {open|closed|all}")
 	issueListCmd.Flags().IntP("limit", "L", 30, "Maximum number of issues to fetch")
 	issueListCmd.Flags().StringP("author", "A", "", "Filter by author")
-	issueListCmd.Flags().StringP("mentioned", "", "", "Filter by mention")
+	issueListCmd.Flags().StringP("mention", "", "", "Filter by mention")
 	issueListCmd.Flags().StringP("milestone", "", "", "Filter by milestone")
 
 	issueCmd.AddCommand(issueViewCmd)
@@ -143,7 +143,7 @@ func issueList(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	mentioned, err := cmd.Flags().GetString("mentioned")
+	mention, err := cmd.Flags().GetString("mention")
 	if err != nil {
 		return err
 	}
@@ -153,7 +153,7 @@ func issueList(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	listResult, err := api.IssueList(apiClient, baseRepo, state, labels, assignee, limit, author, mentioned, milestone)
+	listResult, err := api.IssueList(apiClient, baseRepo, state, labels, assignee, limit, author, mention, milestone)
 	if err != nil {
 		return err
 	}
diff --git a/command/issue_test.go b/command/issue_test.go
@@ -153,7 +153,7 @@ func TestIssueList_withFlags(t *testing.T) {
 	} } }
 	`))
 
-	output, err := RunCommand("issue list -a probablyCher -l web,bug -s open -A foo --mentioned me --milestone 1.x")
+	output, err := RunCommand("issue list -a probablyCher -l web,bug -s open -A foo --mention me --milestone 1.x")
 	if err != nil {
 		t.Errorf("error running command `issue list`: %v", err)
 	}
@@ -171,7 +171,7 @@ No issues match your search in OWNER/REPO
 			Labels    []string
 			States    []string
 			Author    string
-			Mentioned string
+			Mention   string
 			Milestone string
 		}
 	}{}
@@ -181,7 +181,7 @@ No issues match your search in OWNER/REPO
 	eq(t, reqBody.Variables.Labels, []string{"web", "bug"})
 	eq(t, reqBody.Variables.States, []string{"OPEN"})
 	eq(t, reqBody.Variables.Author, "foo")
-	eq(t, reqBody.Variables.Mentioned, "me")
+	eq(t, reqBody.Variables.Mention, "me")
 	eq(t, reqBody.Variables.Milestone, "1.x")
 }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func init() {`
`41`	`41`	`issueListCmd.Flags().StringP("state", "s", "open", "Filter by state: {open\|closed\|all}")`
`42`	`42`	`issueListCmd.Flags().IntP("limit", "L", 30, "Maximum number of issues to fetch")`
`43`	`43`	`issueListCmd.Flags().StringP("author", "A", "", "Filter by author")`
`44`		`- issueListCmd.Flags().StringP("mentioned", "", "", "Filter by mention")`
	`44`	`+ issueListCmd.Flags().StringP("mention", "", "", "Filter by mention")`
`45`	`45`	`issueListCmd.Flags().StringP("milestone", "", "", "Filter by milestone")`
`46`	`46`
`47`	`47`	`issueCmd.AddCommand(issueViewCmd)`
`@@ -143,7 +143,7 @@ func issueList(cmd *cobra.Command, args []string) error {`
`143`	`143`	`return err`
`144`	`144`	`}`
`145`	`145`
`146`		`- mentioned, err := cmd.Flags().GetString("mentioned")`
	`146`	`+ mention, err := cmd.Flags().GetString("mention")`
`147`	`147`	`if err != nil {`
`148`	`148`	`return err`
`149`	`149`	`}`
`@@ -153,7 +153,7 @@ func issueList(cmd *cobra.Command, args []string) error {`
`153`	`153`	`return err`
`154`	`154`	`}`
`155`	`155`
`156`		`- listResult, err := api.IssueList(apiClient, baseRepo, state, labels, assignee, limit, author, mentioned, milestone)`
	`156`	`+ listResult, err := api.IssueList(apiClient, baseRepo, state, labels, assignee, limit, author, mention, milestone)`
`157`	`157`	`if err != nil {`
`158`	`158`	`return err`
`159`	`159`	`}`