Prevent crash when encountering "STALE" check conclusion

mislav · mislav · commit c0bc938ea436 · 2020-03-27T09:54:11.000+01:00
The "STALE" conclusion has shipped this January and is basically a
conclusion that can only be reported by GitHub and not explicitly set by
any integrations.
diff --git a/api/pull_request_test.go b/api/pull_request_test.go
@@ -22,7 +22,9 @@ func TestPullRequest_ChecksStatus(t *testing.T) {
 					{ "status": "COMPLETED",
 					  "conclusion": "FAILURE" },
 					{ "status": "COMPLETED",
-					  "conclusion": "ACTION_REQUIRED" }
+					  "conclusion": "ACTION_REQUIRED" },
+					{ "status": "COMPLETED",
+					  "conclusion": "STALE" }
 				]
 			}
 		}
@@ -32,8 +34,8 @@ func TestPullRequest_ChecksStatus(t *testing.T) {
 	eq(t, err, nil)
 
 	checks := pr.ChecksStatus()
-	eq(t, checks.Total, 7)
-	eq(t, checks.Pending, 2)
+	eq(t, checks.Total, 8)
+	eq(t, checks.Pending, 3)
 	eq(t, checks.Failing, 3)
 	eq(t, checks.Passing, 2)
 }
diff --git a/api/queries_pr.go b/api/queries_pr.go
@@ -120,7 +120,7 @@ func (pr *PullRequest) ChecksStatus() (summary PullRequestChecksStatus) {
 			summary.Passing++
 		case "ERROR", "FAILURE", "CANCELLED", "TIMED_OUT", "ACTION_REQUIRED":
 			summary.Failing++
-		case "EXPECTED", "REQUESTED", "QUEUED", "PENDING", "IN_PROGRESS":
+		case "EXPECTED", "REQUESTED", "QUEUED", "PENDING", "IN_PROGRESS", "STALE":
 			summary.Pending++
 		default:
 			panic(fmt.Errorf("unsupported status: %q", state))

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,9 @@ func TestPullRequest_ChecksStatus(t *testing.T) {`
`22`	`22`	`{ "status": "COMPLETED",`
`23`	`23`	`"conclusion": "FAILURE" },`
`24`	`24`	`{ "status": "COMPLETED",`
`25`		`- "conclusion": "ACTION_REQUIRED" }`
	`25`	`+ "conclusion": "ACTION_REQUIRED" },`
	`26`	`+ { "status": "COMPLETED",`
	`27`	`+ "conclusion": "STALE" }`
`26`	`28`	`]`
`27`	`29`	`}`
`28`	`30`	`}`
`@@ -32,8 +34,8 @@ func TestPullRequest_ChecksStatus(t *testing.T) {`
`32`	`34`	`eq(t, err, nil)`
`33`	`35`
`34`	`36`	`checks := pr.ChecksStatus()`
`35`		`- eq(t, checks.Total, 7)`
`36`		`- eq(t, checks.Pending, 2)`
	`37`	`+ eq(t, checks.Total, 8)`
	`38`	`+ eq(t, checks.Pending, 3)`
`37`	`39`	`eq(t, checks.Failing, 3)`
`38`	`40`	`eq(t, checks.Passing, 2)`
`39`	`41`	`}`