fix tests

vilmibm · vilmibm · commit be9c2ce1275d · 2021-02-05T14:18:11.000-08:00
diff --git a/pkg/cmd/run/list/list_test.go b/pkg/cmd/run/list/list_test.go
@@ -2,9 +2,11 @@ package list
 
 import (
 	"bytes"
+	"io/ioutil"
 	"testing"
 
 	"github.com/cli/cli/pkg/cmdutil"
+	"github.com/cli/cli/pkg/iostreams"
 	"github.com/google/shlex"
 	"github.com/stretchr/testify/assert"
 )
@@ -13,6 +15,7 @@ func TestNewCmdList(t *testing.T) {
 	tests := []struct {
 		name     string
 		cli      string
+		tty      bool
 		wants    ListOptions
 		wantsErr bool
 	}{
@@ -38,7 +41,13 @@ func TestNewCmdList(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			f := &cmdutil.Factory{}
+			io, _, _, _ := iostreams.Test()
+			io.SetStdinTTY(tt.tty)
+			io.SetStdoutTTY(tt.tty)
+
+			f := &cmdutil.Factory{
+				IOStreams: io,
+			}
 
 			argv, err := shlex.Split(tt.cli)
 			assert.NoError(t, err)
@@ -50,8 +59,8 @@ func TestNewCmdList(t *testing.T) {
 			})
 			cmd.SetArgs(argv)
 			cmd.SetIn(&bytes.Buffer{})
-			cmd.SetOut(&bytes.Buffer{})
-			cmd.SetErr(&bytes.Buffer{})
+			cmd.SetOut(ioutil.Discard)
+			cmd.SetErr(ioutil.Discard)
 
 			_, err = cmd.ExecuteC()
 			if tt.wantsErr {
diff --git a/pkg/cmd/run/view/view_test.go b/pkg/cmd/run/view/view_test.go
@@ -2,9 +2,11 @@ package view
 
 import (
 	"bytes"
+	"io/ioutil"
 	"testing"
 
 	"github.com/cli/cli/pkg/cmdutil"
+	"github.com/cli/cli/pkg/iostreams"
 	"github.com/google/shlex"
 	"github.com/stretchr/testify/assert"
 )
@@ -13,6 +15,7 @@ func TestNewCmdView(t *testing.T) {
 	tests := []struct {
 		name     string
 		cli      string
+		tty      bool
 		wants    ViewOptions
 		wantsErr bool
 	}{
@@ -31,7 +34,13 @@ func TestNewCmdView(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			f := &cmdutil.Factory{}
+			io, _, _, _ := iostreams.Test()
+			io.SetStdinTTY(tt.tty)
+			io.SetStdoutTTY(tt.tty)
+
+			f := &cmdutil.Factory{
+				IOStreams: io,
+			}
 
 			argv, err := shlex.Split(tt.cli)
 			assert.NoError(t, err)
@@ -43,8 +52,8 @@ func TestNewCmdView(t *testing.T) {
 			})
 			cmd.SetArgs(argv)
 			cmd.SetIn(&bytes.Buffer{})
-			cmd.SetOut(&bytes.Buffer{})
-			cmd.SetErr(&bytes.Buffer{})
+			cmd.SetOut(ioutil.Discard)
+			cmd.SetErr(ioutil.Discard)
 
 			_, err = cmd.ExecuteC()
 			if tt.wantsErr {
