Add pr create test for git clean state

mislav · mislav · commit bb87f4a2fbe5 · 2019-11-13T19:25:02.000+01:00
diff --git a/command/pr_create_test.go b/command/pr_create_test.go
@@ -37,7 +37,7 @@ func TestPrCreateHelperProcess(*testing.T) {
 	os.Exit(0)
 }
 
-func TestReportsUncommittedChanges(t *testing.T) {
+func TestPRCreate(t *testing.T) {
 	ctx := context.NewBlank()
 	ctx.SetBranch("feature")
 	ctx.SetRemotes(map[string]string{
@@ -60,12 +60,11 @@ func TestReportsUncommittedChanges(t *testing.T) {
 	`))
 
 	origGitCommand := git.GitCommand
+	git.GitCommand = test.StubExecCommand("TestPrCreateHelperProcess", "clean")
 	defer func() {
 		git.GitCommand = origGitCommand
 	}()
 
-	git.GitCommand = test.StubExecCommand("TestPrCreateHelperProcess", "dirty")
-
 	out := bytes.Buffer{}
 	prCreateCmd.SetOut(&out)
 
@@ -93,6 +92,44 @@ func TestReportsUncommittedChanges(t *testing.T) {
 	eq(t, reqBody.Variables.Input.BaseRefName, "master")
 	eq(t, reqBody.Variables.Input.HeadRefName, "feature")
 
+	eq(t, out.String(), "https://github.com/OWNER/REPO/pull/12\n")
+}
+
+func TestPRCreate_ReportsUncommittedChanges(t *testing.T) {
+	ctx := context.NewBlank()
+	ctx.SetBranch("feature")
+	ctx.SetRemotes(map[string]string{
+		"origin": "OWNER/REPO",
+	})
+	initContext = func() context.Context {
+		return ctx
+	}
+	http := initFakeHTTP()
+
+	http.StubResponse(200, bytes.NewBufferString(`
+		{ "data": { "repository": {
+			"id": "REPOID"
+		} } }
+	`))
+	http.StubResponse(200, bytes.NewBufferString(`
+		{ "data": { "createPullRequest": { "pullRequest": {
+			"URL": "https://github.com/OWNER/REPO/pull/12"
+		} } } }
+	`))
+
+	origGitCommand := git.GitCommand
+	git.GitCommand = test.StubExecCommand("TestPrCreateHelperProcess", "dirty")
+	defer func() {
+		git.GitCommand = origGitCommand
+	}()
+
+	out := bytes.Buffer{}
+	prCreateCmd.SetOut(&out)
+
+	RootCmd.SetArgs([]string{"pr", "create", "-t", "mytitle", "-b", "mybody"})
+	_, err := prCreateCmd.ExecuteC()
+	eq(t, err, nil)
+
 	eq(t, out.String(), `Warning: 1 uncommitted change
 https://github.com/OWNER/REPO/pull/12
 `)
