add subdomain wildcard helper

nate smith · nate smith · commit ba3e1e5fb6ce · 2022-01-07T16:51:54.000-06:00
diff --git a/internal/ghinstance/host.go b/internal/ghinstance/host.go
@@ -87,3 +87,10 @@ func HostPrefix(hostname string) string {
 	}
 	return fmt.Sprintf("https://%s/", hostname)
 }
+
+func HostSubdomainWildcard(hostname string) string {
+	if strings.EqualFold(hostname, localhost) {
+		return hostname
+	}
+	return fmt.Sprintf("*.%s", hostname)
+}
diff --git a/pkg/cmd/auth/shared/git_credential.go b/pkg/cmd/auth/shared/git_credential.go
@@ -121,7 +121,10 @@ func (flow *GitCredentialFlow) gitCredentialSetup(hostname, username, password s
 }
 
 func gitCredentialHelperKey(hostname string) string {
-	return fmt.Sprintf("credential.%s.helper", strings.TrimSuffix(ghinstance.HostPrefix(hostname), "/"))
+	host := strings.TrimSuffix(
+		ghinstance.HostPrefix(
+			ghinstance.HostSubdomainWildcard(hostname)), "/")
+	return fmt.Sprintf("credential.%s.helper", host)
 }
 
 func gitCredentialHelper(hostname string) (helper string, err error) {

Original file line number	Diff line number	Diff line change
`@@ -87,3 +87,10 @@ func HostPrefix(hostname string) string {`
`87`	`87`	`}`
`88`	`88`	`return fmt.Sprintf("https://%s/", hostname)`
`89`	`89`	`}`
	`90`	`+`
	`91`	`+func HostSubdomainWildcard(hostname string) string {`
	`92`	`+ if strings.EqualFold(hostname, localhost) {`
	`93`	`+ return hostname`
	`94`	`+ }`
	`95`	`+ return fmt.Sprintf("*.%s", hostname)`
	`96`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,10 @@ func (flow *GitCredentialFlow) gitCredentialSetup(hostname, username, password s`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`func gitCredentialHelperKey(hostname string) string {`
`124`		`- return fmt.Sprintf("credential.%s.helper", strings.TrimSuffix(ghinstance.HostPrefix(hostname), "/"))`
	`124`	`+ host := strings.TrimSuffix(`
	`125`	`+ ghinstance.HostPrefix(`
	`126`	`+ ghinstance.HostSubdomainWildcard(hostname)), "/")`
	`127`	`+ return fmt.Sprintf("credential.%s.helper", host)`
`125`	`128`	`}`
`126`	`129`
`127`	`130`	`func gitCredentialHelper(hostname string) (helper string, err error) {`