Remove caching

probablycorey · probablycorey · commit b69dff172c14 · 2019-10-16T16:26:32.000-07:00
I removed this because it was making tests fail!
diff --git a/git/git.go b/git/git.go
@@ -10,13 +10,7 @@ import (
 	"strings"
 )
 
-var cachedDir string
-
 func Dir() (string, error) {
-	if cachedDir != "" {
-		return cachedDir, nil
-	}
-
 	dirCmd := exec.Command("git", "rev-parse", "-q", "--git-dir")
 	dirCmd.Stderr = nil
 	output, err := dirCmd.Output()
@@ -33,7 +27,6 @@ func Dir() (string, error) {
 		gitDir = filepath.Clean(gitDir)
 	}
 
-	cachedDir = gitDir
 	return gitDir, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -10,13 +10,7 @@ import (`
`10`	`10`	`"strings"`
`11`	`11`	`)`
`12`	`12`
`13`		`-var cachedDir string`
`14`		`-`
`15`	`13`	`func Dir() (string, error) {`
`16`		`- if cachedDir != "" {`
`17`		`- return cachedDir, nil`
`18`		`- }`
`19`		`-`
`20`	`14`	`dirCmd := exec.Command("git", "rev-parse", "-q", "--git-dir")`
`21`	`15`	`dirCmd.Stderr = nil`
`22`	`16`	`output, err := dirCmd.Output()`
`@@ -33,7 +27,6 @@ func Dir() (string, error) {`
`33`	`27`	`gitDir = filepath.Clean(gitDir)`
`34`	`28`	`}`
`35`	`29`
`36`		`- cachedDir = gitDir`
`37`	`30`	`return gitDir, nil`
`38`	`31`	`}`
`39`	`32`