take out auto browser flow

vilmibm · vilmibm · commit b1a6346e0788 · 2020-08-18T17:57:52.000-05:00
diff --git a/cmd/gh/main.go b/cmd/gh/main.go
@@ -134,9 +134,7 @@ func main() {
 		}
 	}
 
-	// TODO verify host auth in heavy user input commands (creates, review)
 	// TODO improve error messaging for 401
-	// TODO remove old auth flow path
 
 	rootCmd.SetArgs(expandedArgs)
 
diff --git a/pkg/cmd/factory/http.go b/pkg/cmd/factory/http.go
@@ -1,7 +1,6 @@
 package factory
 
 import (
-	"errors"
 	"fmt"
 	"net/http"
 	"os"
@@ -30,20 +29,9 @@ func httpClient(io *iostreams.IOStreams, cfg config.Config, appVersion string, s
 
 			hostname := ghinstance.NormalizeHostname(req.URL.Hostname())
 			token, err := cfg.Get(hostname, "oauth_token")
-			if token == "" {
-				var notFound *config.NotFoundError
-				// TODO: check if stdout is TTY too
-				if errors.As(err, &notFound) && io.IsStdinTTY() {
-					// interactive OAuth flow
-					token, err = config.AuthFlowWithConfig(cfg, hostname, "Notice: authentication required", nil)
-				}
-				if err != nil {
-					return "", err
-				}
-				if token == "" {
-					// TODO: instruct user how to manually authenticate
-					return "", fmt.Errorf("authentication required for %s", hostname)
-				}
+			if err != nil || token == "" {
+				// Users shouldn't see this because of the pre-execute auth check on commands
+				return "", fmt.Errorf("authentication required for %s; please run `gh auth login -h%s", hostname, hostname)
 			}
 
 			return fmt.Sprintf("token %s", token), nil

Original file line number	Diff line number	Diff line change
`@@ -134,9 +134,7 @@ func main() {`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`
`137`		`- // TODO verify host auth in heavy user input commands (creates, review)`
`138`	`137`	`// TODO improve error messaging for 401`
`139`		`- // TODO remove old auth flow path`
`140`	`138`
`141`	`139`	`rootCmd.SetArgs(expandedArgs)`
`142`	`140`