Remove update check from extension list

samcoe · samcoe · commit af849ca25398 · 2022-03-02T21:40:55.000+02:00
diff --git a/pkg/cmd/extension/command.go b/pkg/cmd/extension/command.go
@@ -45,11 +45,10 @@ func NewCmdExtension(f *cmdutil.Factory) *cobra.Command {
 			Aliases: []string{"ls"},
 			Args:    cobra.NoArgs,
 			RunE: func(cmd *cobra.Command, args []string) error {
-				cmds := m.List(true)
+				cmds := m.List(false)
 				if len(cmds) == 0 {
 					return errors.New("no extensions installed")
 				}
-				cs := io.ColorScheme()
 				t := utils.NewTablePrinter(io)
 				for _, c := range cmds {
 					var repo string
@@ -61,11 +60,6 @@ func NewCmdExtension(f *cmdutil.Factory) *cobra.Command {
 
 					t.AddField(fmt.Sprintf("gh %s", c.Name()), nil, nil)
 					t.AddField(repo, nil, nil)
-					var updateAvailable string
-					if c.UpdateAvailable() {
-						updateAvailable = "Upgrade available"
-					}
-					t.AddField(updateAvailable, nil, cs.Green)
 					t.EndRow()
 				}
 				return t.Render()
diff --git a/pkg/cmd/extension/command_test.go b/pkg/cmd/extension/command_test.go
@@ -296,10 +296,12 @@ func TestNewCmdExtension(t *testing.T) {
 					return []extensions.Extension{ex1, ex2}
 				}
 				return func(t *testing.T) {
-					assert.Equal(t, 1, len(em.ListCalls()))
+					calls := em.ListCalls()
+					assert.Equal(t, 1, len(calls))
+					assert.False(t, calls[0].IncludeMetadata)
 				}
 			},
-			wantStdout: "gh test\tcli/gh-test\t\ngh test2\tcli/gh-test2\tUpgrade available\n",
+			wantStdout: "gh test\tcli/gh-test\ngh test2\tcli/gh-test2\n",
 		},
 		{
 			name: "create extension interactive",
diff --git a/pkg/extensions/manager_mock.go b/pkg/extensions/manager_mock.go

Original file line number	Diff line number	Diff line change
`@@ -296,10 +296,12 @@ func TestNewCmdExtension(t *testing.T) {`
`296`	`296`	`return []extensions.Extension{ex1, ex2}`
`297`	`297`	`}`
`298`	`298`	`return func(t *testing.T) {`
`299`		`- assert.Equal(t, 1, len(em.ListCalls()))`
	`299`	`+ calls := em.ListCalls()`
	`300`	`+ assert.Equal(t, 1, len(calls))`
	`301`	`+ assert.False(t, calls[0].IncludeMetadata)`
`300`	`302`	`}`
`301`	`303`	`},`
`302`		`- wantStdout: "gh test\tcli/gh-test\t\ngh test2\tcli/gh-test2\tUpgrade available\n",`
	`304`	`+ wantStdout: "gh test\tcli/gh-test\ngh test2\tcli/gh-test2\n",`
`303`	`305`	`},`
`304`	`306`	`{`
`305`	`307`	`name: "create extension interactive",`