Print friendly error when "gh repo clone" is missing required argument

emhagman · emhagman · commit af1d8a60e027 · 2020-10-21T23:23:39.000-04:00
diff --git a/pkg/cmd/repo/clone/clone.go b/pkg/cmd/repo/clone/clone.go
@@ -1,6 +1,7 @@
 package clone
 
 import (
+	"errors"
 	"fmt"
 	"net/http"
 	"strings"
@@ -37,8 +38,13 @@ func NewCmdClone(f *cmdutil.Factory, runF func(*CloneOptions) error) *cobra.Comm
 	cmd := &cobra.Command{
 		DisableFlagsInUseLine: true,
 
-		Use:   "clone <repository> [<directory>] [-- <gitflags>...]",
-		Args:  cobra.MinimumNArgs(1),
+		Use: "clone <repository> [<directory>] [-- <gitflags>...]",
+		Args: func(cmd *cobra.Command, args []string) error {
+			if len(args) == 0 {
+				return &cmdutil.FlagError{Err: errors.New("cannot clone: no repository name given")}
+			}
+			return nil
+		},
 		Short: "Clone a repository locally",
 		Long: heredoc.Doc(`
 			Clone a GitHub repository locally.
diff --git a/pkg/cmd/repo/clone/clone_test.go b/pkg/cmd/repo/clone/clone_test.go
@@ -210,3 +210,10 @@ func Test_RepoClone_flagError(t *testing.T) {
 		t.Errorf("unexpected error %v", err)
 	}
 }
+
+func Test_RepoClone_noArgError(t *testing.T) {
+	_, err := runCloneCommand(nil, "")
+	if err == nil || err.Error() != "cannot clone: no repository name given" {
+		t.Errorf("unexpected error %v", err)
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -210,3 +210,10 @@ func Test_RepoClone_flagError(t *testing.T) {`
`210`	`210`	`t.Errorf("unexpected error %v", err)`
`211`	`211`	`}`
`212`	`212`	`}`
	`213`	`+`
	`214`	`+func Test_RepoClone_noArgError(t *testing.T) {`
	`215`	`+ _, err := runCloneCommand(nil, "")`
	`216`	`+ if err == nil \|\| err.Error() != "cannot clone: no repository name given" {`
	`217`	`+ t.Errorf("unexpected error %v", err)`
	`218`	`+ }`
	`219`	`+}`