review feedback

nate smith · nate smith · commit 9f451d9eef69 · 2021-04-29T16:06:26.000-05:00
diff --git a/cmd/gh/main.go b/cmd/gh/main.go
@@ -178,7 +178,7 @@ func mainRun() exitCode {
 
 		if strings.Contains(err.Error(), "Incorrect function") {
 			fmt.Fprintln(stderr, "You appear to be running in MinTTY without pseudo terminal support.")
-			fmt.Fprintln(stderr, "To learn about workarounds for this error, gh help mintty")
+			fmt.Fprintln(stderr, "To learn about workarounds for this error, run: gh help mintty")
 			return exitError
 		}
 
diff --git a/pkg/cmd/root/help_topic.go b/pkg/cmd/root/help_topic.go
@@ -15,11 +15,11 @@ var HelpTopics = map[string]map[string]string{
 
 			There are a few workarounds to make gh work with MinTTY:
 
-			- Reinstall Git for Windows. 
-			  Be sure to check the box "Enable experimental support for pseudo consoles".
+			- Reinstall Git for Windows, checking "Enable experimental support for pseudo consoles".
 
-			- Use a different terminal emulator with Git for Windows like Windows Terminal or cmd.exe.
-			  Try running "C:\Program Files\Git\bin\bash.exe" in one of those other terminal emulators.
+			- Use a different terminal emulator with Git for Windows like Windows Terminal.
+			  You can run "C:\Program Files\Git\bin\bash.exe" from any terminal emulator to continue
+			  using all of the tooling in Git For Windows without MinTTY.
 
 			- Prefix invocations of gh with winpty, eg: "winpty gh auth login".
 			  NOTE: this can lead to some UI bugs.

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ func mainRun() exitCode {`
`178`	`178`
`179`	`179`	`if strings.Contains(err.Error(), "Incorrect function") {`
`180`	`180`	`fmt.Fprintln(stderr, "You appear to be running in MinTTY without pseudo terminal support.")`
`181`		`- fmt.Fprintln(stderr, "To learn about workarounds for this error, gh help mintty")`
	`181`	`+ fmt.Fprintln(stderr, "To learn about workarounds for this error, run: gh help mintty")`
`182`	`182`	`return exitError`
`183`	`183`	`}`
`184`	`184`