don't check Fprintf error

nate smith · nate smith · commit 98d3b7cc795f · 2021-07-12T13:05:49.000-05:00
we don't ever check the return of Fprintf anywhere else in the codebase
so doing it here suggests that it's a special case. if it's something we
should be doing we can circle back and do it more consistently.
diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go
@@ -154,8 +154,8 @@ func runBrowse(opts *BrowseOptions) error {
 	}
 
 	if opts.NoBrowserFlag {
-		_, err := fmt.Fprintf(opts.IO.Out, "%s\n", url)
-		return err
+		fmt.Fprintf(opts.IO.Out, "%s\n", url)
+		return nil
 	} else {
 		if opts.IO.IsStdoutTTY() {
 			fmt.Fprintf(opts.IO.Out, "now opening %s in browser\n", url)
