Ignore scope suggestions for http 422 (cli#4809)

despreston · mislav · web-flow · commit 8f9548fd37ad · 2021-12-01T18:13:48.000Z
HTTP 422 messages are for validation errors, but OAUTH permissions
suggestions get printed anyways. Most times, the user probably has the
right permissions. This fix adds the check to avoid printing a confusing
message.

Co-authored-by: Mislav Marohnić &lt;mislav@github.com&gt;
diff --git a/api/client.go b/api/client.go
@@ -206,7 +206,7 @@ func (err HTTPError) ScopesSuggestion() string {
 // ScopesSuggestion is an error messaging utility that prints the suggestion to request additional OAuth
 // scopes in case a server response indicates that there are missing scopes.
 func ScopesSuggestion(resp *http.Response) string {
-	if resp.StatusCode < 400 || resp.StatusCode > 499 {
+	if resp.StatusCode < 400 || resp.StatusCode > 499 || resp.StatusCode == 422 {
 		return ""
 	}
 
diff --git a/api/client_test.go b/api/client_test.go
@@ -208,6 +208,11 @@ func TestHTTPError_ScopesSuggestion(t *testing.T) {
 			resp: makeResponse(404, "https://api.github.com/gists", "", "gist, delete_repo"),
 			want: ``,
 		},
+		{
+			name: "http code is 422",
+			resp: makeResponse(422, "https://api.github.com/gists", "", "gist"),
+			want: "",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ func (err HTTPError) ScopesSuggestion() string {`
`206`	`206`	`// ScopesSuggestion is an error messaging utility that prints the suggestion to request additional OAuth`
`207`	`207`	`// scopes in case a server response indicates that there are missing scopes.`
`208`	`208`	`func ScopesSuggestion(resp *http.Response) string {`
`209`		`- if resp.StatusCode < 400 \|\| resp.StatusCode > 499 {`
	`209`	`+ if resp.StatusCode < 400 \|\| resp.StatusCode > 499 \|\| resp.StatusCode == 422 {`
`210`	`210`	`return ""`
`211`	`211`	`}`
`212`	`212`