Add filter issues by author

eddumelendez · eddumelendez · commit 8e7ba907b195 · 2020-03-09T18:50:23.000-06:00
diff --git a/api/queries_issue.go b/api/queries_issue.go
@@ -55,6 +55,9 @@ const fragments = `
 			}
 			totalCount
 		}
+		author {
+			login
+		}
 	}
 `
 
@@ -171,7 +174,7 @@ func IssueStatus(client *Client, repo ghrepo.Interface, currentUsername string)
 	return &payload, nil
 }
 
-func IssueList(client *Client, repo ghrepo.Interface, state string, labels []string, assigneeString string, limit int) ([]Issue, error) {
+func IssueList(client *Client, repo ghrepo.Interface, state string, labels []string, assigneeString string, limit int, authorString string) ([]Issue, error) {
 	var states []string
 	switch state {
 	case "open", "":
@@ -185,10 +188,10 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str
 	}
 
 	query := fragments + `
-	query($owner: String!, $repo: String!, $limit: Int, $endCursor: String, $states: [IssueState!] = OPEN, $labels: [String!], $assignee: String) {
+	query($owner: String!, $repo: String!, $limit: Int, $endCursor: String, $states: [IssueState!] = OPEN, $labels: [String!], $assignee: String, $author: String) {
 		repository(owner: $owner, name: $repo) {
 			hasIssuesEnabled
-			issues(first: $limit, after: $endCursor, orderBy: {field: CREATED_AT, direction: DESC}, states: $states, labels: $labels, filterBy: {assignee: $assignee}) {
+			issues(first: $limit, after: $endCursor, orderBy: {field: CREATED_AT, direction: DESC}, states: $states, labels: $labels, filterBy: {assignee: $assignee, createdBy: $author}) {
 				nodes {
 					...issue
 				}
@@ -212,6 +215,9 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str
 	if assigneeString != "" {
 		variables["assignee"] = assigneeString
 	}
+	if authorString != "" {
+		variables["author"] = authorString
+	}
 
 	var response struct {
 		Repository struct {
diff --git a/api/queries_issue_test.go b/api/queries_issue_test.go
@@ -38,7 +38,7 @@ func TestIssueList(t *testing.T) {
 	} } }
 	`))
 
-	_, err := IssueList(client, ghrepo.FromFullName("OWNER/REPO"), "open", []string{}, "", 251)
+	_, err := IssueList(client, ghrepo.FromFullName("OWNER/REPO"), "open", []string{}, "", 251, "")
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}
diff --git a/command/issue.go b/command/issue.go
@@ -37,6 +37,7 @@ func init() {
 	issueListCmd.Flags().StringSliceP("label", "l", nil, "Filter by label")
 	issueListCmd.Flags().StringP("state", "s", "", "Filter by state: {open|closed|all}")
 	issueListCmd.Flags().IntP("limit", "L", 30, "Maximum number of issues to fetch")
+	issueListCmd.Flags().StringP("author", "A", "", "Filter by author")
 
 	issueViewCmd.Flags().BoolP("preview", "p", false, "Display preview of issue content")
 }
@@ -109,9 +110,14 @@ func issueList(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
+	author, err := cmd.Flags().GetString("author")
+	if err != nil {
+		return err
+	}
+
 	fmt.Fprintf(colorableErr(cmd), "\nIssues for %s\n\n", ghrepo.FullName(baseRepo))
 
-	issues, err := api.IssueList(apiClient, baseRepo, state, labels, assignee, limit)
+	issues, err := api.IssueList(apiClient, baseRepo, state, labels, assignee, limit, author)
 	if err != nil {
 		return err
 	}
diff --git a/command/issue_test.go b/command/issue_test.go
@@ -136,7 +136,7 @@ func TestIssueList_withFlags(t *testing.T) {
 	} } }
 	`))
 
-	output, err := RunCommand(issueListCmd, "issue list -a probablyCher -l web,bug -s open")
+	output, err := RunCommand(issueListCmd, "issue list -a probablyCher -l web,bug -s open -A foo")
 	if err != nil {
 		t.Errorf("error running command `issue list`: %v", err)
 	}
@@ -154,13 +154,15 @@ No issues match your search
 			Assignee string
 			Labels   []string
 			States   []string
+			Author   string
 		}
 	}{}
 	json.Unmarshal(bodyBytes, &reqBody)
 
 	eq(t, reqBody.Variables.Assignee, "probablyCher")
 	eq(t, reqBody.Variables.Labels, []string{"web", "bug"})
 	eq(t, reqBody.Variables.States, []string{"OPEN"})
+	eq(t, reqBody.Variables.Author, "foo")
 }
 
 func TestIssueList_nullAssigneeLabels(t *testing.T) {
diff --git a/test/fixtures/issueList.json b/test/fixtures/issueList.json
@@ -15,6 +15,9 @@
                   }
                 ],
                 "totalCount": 1
+              },
+              "author": {
+                "login": "foo"
               }
           },
           {
@@ -28,6 +31,9 @@
                   }
                 ],
                 "totalCount": 1
+              },
+              "author": {
+                "login": "bar"
               }
           },
           {
@@ -41,6 +47,9 @@
                   }
                 ],
                 "totalCount": 1
+              },
+              "author": {
+                "login": "bar"
               }
           }
         ]

Original file line number	Diff line number	Diff line change
@@ -55,6 +55,9 @@ const fragments = `
`55`	`55`	`}`
`56`	`56`	`totalCount`
`57`	`57`	`}`
	`58`	`+ author {`
	`59`	`+ login`
	`60`	`+ }`
`58`	`61`	`}`
`59`	`62`	`
`60`	`63`
`@@ -171,7 +174,7 @@ func IssueStatus(client *Client, repo ghrepo.Interface, currentUsername string)`
`171`	`174`	`return &payload, nil`
`172`	`175`	`}`
`173`	`176`
`174`		`-func IssueList(client *Client, repo ghrepo.Interface, state string, labels []string, assigneeString string, limit int) ([]Issue, error) {`
	`177`	`+func IssueList(client *Client, repo ghrepo.Interface, state string, labels []string, assigneeString string, limit int, authorString string) ([]Issue, error) {`
`175`	`178`	`var states []string`
`176`	`179`	`switch state {`
`177`	`180`	`case "open", "":`
`@@ -185,10 +188,10 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str`
`185`	`188`	`}`
`186`	`189`
`187`	`190`	query := fragments + `
`188`		`- query($owner: String!, $repo: String!, $limit: Int, $endCursor: String, $states: [IssueState!] = OPEN, $labels: [String!], $assignee: String) {`
	`191`	`+ query($owner: String!, $repo: String!, $limit: Int, $endCursor: String, $states: [IssueState!] = OPEN, $labels: [String!], $assignee: String, $author: String) {`
`189`	`192`	`repository(owner: $owner, name: $repo) {`
`190`	`193`	`hasIssuesEnabled`
`191`		`- issues(first: $limit, after: $endCursor, orderBy: {field: CREATED_AT, direction: DESC}, states: $states, labels: $labels, filterBy: {assignee: $assignee}) {`
	`194`	`+ issues(first: $limit, after: $endCursor, orderBy: {field: CREATED_AT, direction: DESC}, states: $states, labels: $labels, filterBy: {assignee: $assignee, createdBy: $author}) {`
`192`	`195`	`nodes {`
`193`	`196`	`...issue`
`194`	`197`	`}`
`@@ -212,6 +215,9 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str`
`212`	`215`	`if assigneeString != "" {`
`213`	`216`	`variables["assignee"] = assigneeString`
`214`	`217`	`}`
	`218`	`+ if authorString != "" {`
	`219`	`+ variables["author"] = authorString`
	`220`	`+ }`
`215`	`221`
`216`	`222`	`var response struct {`
`217`	`223`	`Repository struct {`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func TestIssueList(t *testing.T) {`
`38`	`38`	`} } }`
`39`	`39`	`))
`40`	`40`
`41`		`- _, err := IssueList(client, ghrepo.FromFullName("OWNER/REPO"), "open", []string{}, "", 251)`
	`41`	`+ _, err := IssueList(client, ghrepo.FromFullName("OWNER/REPO"), "open", []string{}, "", 251, "")`
`42`	`42`	`if err != nil {`
`43`	`43`	`t.Fatalf("unexpected error: %v", err)`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,9 @@`
`15`	`15`	`}`
`16`	`16`	`],`
`17`	`17`	`"totalCount": 1`
	`18`	`+ },`
	`19`	`+ "author": {`
	`20`	`+ "login": "foo"`
`18`	`21`	`}`
`19`	`22`	`},`
`20`	`23`	`{`
`@@ -28,6 +31,9 @@`
`28`	`31`	`}`
`29`	`32`	`],`
`30`	`33`	`"totalCount": 1`
	`34`	`+ },`
	`35`	`+ "author": {`
	`36`	`+ "login": "bar"`
`31`	`37`	`}`
`32`	`38`	`},`
`33`	`39`	`{`
`@@ -41,6 +47,9 @@`
`41`	`47`	`}`
`42`	`48`	`],`
`43`	`49`	`"totalCount": 1`
	`50`	`+ },`
	`51`	`+ "author": {`
	`52`	`+ "login": "bar"`
`44`	`53`	`}`
`45`	`54`	`}`
`46`	`55`	`]`