Init slice with provided capacity if it's known in advance

Dasio · Dasio · commit 8aa46c236e4a · 2020-02-24T22:16:41.000+01:00
diff --git a/.gitignore b/.gitignore
@@ -9,6 +9,9 @@
 # VS Code
 .vscode
 
+# IntelliJ
+.idea
+
 # macOS
 .DS_Store
 
diff --git a/api/queries_repo.go b/api/queries_repo.go
@@ -97,7 +97,7 @@ type RepoNetworkResult struct {
 
 // RepoNetwork inspects the relationship between multiple GitHub repositories
 func RepoNetwork(client *Client, repos []ghrepo.Interface) (RepoNetworkResult, error) {
-	queries := []string{}
+	queries := make([]string, 0, len(repos))
 	for i, repo := range repos {
 		queries = append(queries, fmt.Sprintf(`
 		repo_%03d: repository(owner: %q, name: %q) {
@@ -150,7 +150,7 @@ func RepoNetwork(client *Client, repos []ghrepo.Interface) (RepoNetworkResult, e
 		return result, err
 	}
 
-	keys := []string{}
+	keys := make([]string, 0, len(graphqlResult))
 	for key := range graphqlResult {
 		keys = append(keys, key)
 	}
diff --git a/command/issue.go b/command/issue.go
@@ -429,7 +429,7 @@ func labelList(issue api.Issue) string {
 		return ""
 	}
 
-	labelNames := []string{}
+	labelNames := make([]string, 0, len(issue.Labels.Nodes))
 	for _, label := range issue.Labels.Nodes {
 		labelNames = append(labelNames, label.Name)
 	}
diff --git a/command/pr_checkout.go b/command/pr_checkout.go
@@ -38,8 +38,7 @@ func prCheckout(cmd *cobra.Command, args []string) error {
 		headRemote, _ = remotes.FindByRepo(pr.HeadRepositoryOwner.Login, pr.HeadRepository.Name)
 	}
 
-	cmdQueue := [][]string{}
-
+	cmdQueue := make([][]string, 0, 4)
 	newBranchName := pr.HeadRefName
 	if headRemote != nil {
 		// there is an existing git remote for PR head
diff --git a/command/root.go b/command/root.go
@@ -97,7 +97,7 @@ var initContext = func() context.Context {
 // BasicClient returns an API client that borrows from but does not depend on
 // user configuration
 func BasicClient() (*api.Client, error) {
-	opts := []api.ClientOption{}
+	opts := make([]api.ClientOption, 0, 1)
 	if verbose := os.Getenv("DEBUG"); verbose != "" {
 		opts = append(opts, apiVerboseLog())
 	}
@@ -122,7 +122,7 @@ var apiClientForContext = func(ctx context.Context) (*api.Client, error) {
 	if err != nil {
 		return nil, err
 	}
-	opts := []api.ClientOption{}
+	opts := make([]api.ClientOption, 0, 4)
 	if verbose := os.Getenv("DEBUG"); verbose != "" {
 		opts = append(opts, apiVerboseLog())
 	}
diff --git a/command/title_body_survey.go b/command/title_body_survey.go
@@ -54,7 +54,7 @@ func selectTemplate(templatePaths []string) (string, error) {
 		Index int
 	}{}
 	if len(templatePaths) > 1 {
-		templateNames := []string{}
+		templateNames := make([]string, 0, len(templatePaths))
 		for _, p := range templatePaths {
 			templateNames = append(templateNames, githubtemplate.ExtractName(p))
 		}
@@ -110,7 +110,7 @@ func titleBodySurvey(cmd *cobra.Command, providedTitle string, providedBody stri
 		},
 	}
 
-	qs := []*survey.Question{}
+	var qs = []*survey.Question{}
 	if providedTitle == "" {
 		qs = append(qs, titleQuestion)
 	}
diff --git a/context/context.go b/context/context.go
@@ -38,7 +38,7 @@ func ResolveRemotesToRepos(remotes Remotes, client *api.Client, base string) (Re
 	hasBaseOverride := base != ""
 	baseOverride := ghrepo.FromFullName(base)
 	foundBaseOverride := false
-	repos := []ghrepo.Interface{}
+	repos := make([]ghrepo.Interface, 0, lenRemotesForLookup)
 	for _, r := range remotes[:lenRemotesForLookup] {
 		repos = append(repos, r)
 		if ghrepo.IsSame(r, baseOverride) {
diff --git a/git/ssh_config.go b/git/ssh_config.go
@@ -57,7 +57,7 @@ func ParseSSHConfig() SSHAliasMap {
 		configFiles = append([]string{userConfig}, configFiles...)
 	}
 
-	openFiles := []io.Reader{}
+	openFiles := make([]io.Reader, 0, len(configFiles))
 	for _, file := range configFiles {
 		f, err := os.Open(file)
 		if err != nil {
diff --git a/internal/cobrafish/completion.go b/internal/cobrafish/completion.go
@@ -117,7 +117,7 @@ func flagRequiresArgumentCompletion(flag *pflag.Flag) string {
 }
 
 func subCommandPath(rootCmd *cobra.Command, cmd *cobra.Command) string {
-	path := []string{}
+	path := make([]string, 0, 1)
 	currentCmd := cmd
 	if rootCmd == cmd {
 		return ""
@@ -142,7 +142,7 @@ func rangeCommands(cmd *cobra.Command, callback func(subCmd *cobra.Command)) {
 
 func commandCompletionCondition(rootCmd, cmd *cobra.Command) string {
 	localNonPersistentFlags := cmd.LocalNonPersistentFlags()
-	bareConditions := []string{}
+	bareConditions := make([]string, 0, 1)
 	if rootCmd != cmd {
 		bareConditions = append(bareConditions, fmt.Sprintf("__fish_%s_seen_subcommand_path %s", rootCmd.Name(), subCommandPath(rootCmd, cmd)))
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,7 @@ func labelList(issue api.Issue) string {`
`429`	`429`	`return ""`
`430`	`430`	`}`
`431`	`431`
`432`		`- labelNames := []string{}`
	`432`	`+ labelNames := make([]string, 0, len(issue.Labels.Nodes))`
`433`	`433`	`for _, label := range issue.Labels.Nodes {`
`434`	`434`	`labelNames = append(labelNames, label.Name)`
`435`	`435`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,7 @@ func prCheckout(cmd *cobra.Command, args []string) error {`
`38`	`38`	`headRemote, _ = remotes.FindByRepo(pr.HeadRepositoryOwner.Login, pr.HeadRepository.Name)`
`39`	`39`	`}`
`40`	`40`
`41`		`- cmdQueue := [][]string{}`
`42`		`-`
	`41`	`+ cmdQueue := make([][]string, 0, 4)`
`43`	`42`	`newBranchName := pr.HeadRefName`
`44`	`43`	`if headRemote != nil {`
`45`	`44`	`// there is an existing git remote for PR head`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ var initContext = func() context.Context {`
`97`	`97`	`// BasicClient returns an API client that borrows from but does not depend on`
`98`	`98`	`// user configuration`
`99`	`99`	`func BasicClient() (*api.Client, error) {`
`100`		`- opts := []api.ClientOption{}`
	`100`	`+ opts := make([]api.ClientOption, 0, 1)`
`101`	`101`	`if verbose := os.Getenv("DEBUG"); verbose != "" {`
`102`	`102`	`opts = append(opts, apiVerboseLog())`
`103`	`103`	`}`
`@@ -122,7 +122,7 @@ var apiClientForContext = func(ctx context.Context) (*api.Client, error) {`
`122`	`122`	`if err != nil {`
`123`	`123`	`return nil, err`
`124`	`124`	`}`
`125`		`- opts := []api.ClientOption{}`
	`125`	`+ opts := make([]api.ClientOption, 0, 4)`
`126`	`126`	`if verbose := os.Getenv("DEBUG"); verbose != "" {`
`127`	`127`	`opts = append(opts, apiVerboseLog())`
`128`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ func selectTemplate(templatePaths []string) (string, error) {`
`54`	`54`	`Index int`
`55`	`55`	`}{}`
`56`	`56`	`if len(templatePaths) > 1 {`
`57`		`- templateNames := []string{}`
	`57`	`+ templateNames := make([]string, 0, len(templatePaths))`
`58`	`58`	`for _, p := range templatePaths {`
`59`	`59`	`templateNames = append(templateNames, githubtemplate.ExtractName(p))`
`60`	`60`	`}`
`@@ -110,7 +110,7 @@ func titleBodySurvey(cmd *cobra.Command, providedTitle string, providedBody stri`
`110`	`110`	`},`
`111`	`111`	`}`
`112`	`112`
`113`		`- qs := []*survey.Question{}`
	`113`	`+ var qs = []*survey.Question{}`
`114`	`114`	`if providedTitle == "" {`
`115`	`115`	`qs = append(qs, titleQuestion)`
`116`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func ParseSSHConfig() SSHAliasMap {`
`57`	`57`	`configFiles = append([]string{userConfig}, configFiles...)`
`58`	`58`	`}`
`59`	`59`
`60`		`- openFiles := []io.Reader{}`
	`60`	`+ openFiles := make([]io.Reader, 0, len(configFiles))`
`61`	`61`	`for _, file := range configFiles {`
`62`	`62`	`f, err := os.Open(file)`
`63`	`63`	`if err != nil {`