Whoops

probablycorey · probablycorey · commit 6f339285b5b9 · 2019-12-11T16:48:48.000-08:00
diff --git a/main.go b/main.go
@@ -8,6 +8,7 @@ import (
 	"github.com/github/gh-cli/command"
 	"github.com/github/gh-cli/update"
 	"github.com/github/gh-cli/utils"
+	"github.com/mattn/go-isatty"
 	"github.com/mgutz/ansi"
 	"github.com/mitchellh/go-homedir"
 )
@@ -45,9 +46,8 @@ func main() {
 }
 
 func shouldCheckForUpdate() bool {
-	// errFd := os.Stderr.Fd()
-	// return updaterEnabled != "" && (isatty.IsTerminal(errFd) || isatty.IsCygwinTerminal(errFd))
-	return true
+	errFd := os.Stderr.Fd()
+	return updaterEnabled != "" && (isatty.IsTerminal(errFd) || isatty.IsCygwinTerminal(errFd))
 }
 
 func checkForUpdate(currentVersion string) (*update.ReleaseInfo, error) {

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ import (`
`8`	`8`	`"github.com/github/gh-cli/command"`
`9`	`9`	`"github.com/github/gh-cli/update"`
`10`	`10`	`"github.com/github/gh-cli/utils"`
	`11`	`+ "github.com/mattn/go-isatty"`
`11`	`12`	`"github.com/mgutz/ansi"`
`12`	`13`	`"github.com/mitchellh/go-homedir"`
`13`	`14`	`)`
`@@ -45,9 +46,8 @@ func main() {`
`45`	`46`	`}`
`46`	`47`
`47`	`48`	`func shouldCheckForUpdate() bool {`
`48`		`- // errFd := os.Stderr.Fd()`
`49`		`- // return updaterEnabled != "" && (isatty.IsTerminal(errFd) \|\| isatty.IsCygwinTerminal(errFd))`
`50`		`- return true`
	`49`	`+ errFd := os.Stderr.Fd()`
	`50`	`+ return updaterEnabled != "" && (isatty.IsTerminal(errFd) \|\| isatty.IsCygwinTerminal(errFd))`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`func checkForUpdate(currentVersion string) (*update.ReleaseInfo, error) {`