We got the browser to open on gh browse, now we're working towards making it specific to the argument passed in. Mini wingit add .!

bchadwic · bchadwic · commit 68ce66801b5f · 2021-05-15T21:09:13.000-07:00
diff --git a/cmd/gh/main.go b/cmd/gh/main.go
@@ -45,6 +45,7 @@ const (
 func main() {
 	code := mainRun()
 	os.Exit(int(code))
+
 }
 
 func mainRun() exitCode {
diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go
@@ -1,35 +1,34 @@
 package browse
 
 import (
-	"github.com/MakeNowJust/heredoc"
+	"fmt"
+	"os"
+
 	"github.com/cli/cli/pkg/cmdutil"
+	"github.com/cli/cli/pkg/iostreams"
 	"github.com/spf13/cobra"
 )
 
 func NewCmdBrowse(f *cmdutil.Factory) *cobra.Command {
+
 	cmd := &cobra.Command{
-		Use:   "browse <command>",
-		Short: "",
-		Long:  `Open GitHub in the browser`,
-		Example: heredoc.Doc(`
-			$ gh browse issue "217"
-			$ gh browse file "src/main.java"
-			$ gh browse branch "master"
-		`),
-		Annotations: map[string]string{
-			"IsCore": "true", 
-			"help:arguments": heredoc.Doc(`
-				Branch names, pr numbers, issue numbers, and file paths
-				can be supplied as arguments in the following formats:
-		 		- by number, e.g. “123”; or
-		 		- by description, e.g. “index.js”
-		 
-			`),
-		},
+		Long: "Hello world", // displays when you are on the help page of this command
+		Short: "Open GitHub in the browser", // displays in the gh root help 
+		Use:    "browse", // necessary!!! This is the cmd that gets passed on the prompt
+		Run: func(cmd *cobra.Command, args []string) { // run gets rid of the usage
+			openInBrowser()
+ 	   	},
 	}
 
-	cmdutil.EnableRepoOverride(cmd, f) 
-
+	cmdutil.EnableRepoOverride(cmd, f)
 
 	return cmd
 }
+
+func openInBrowser() {
+	fmt.Println("");
+	IO,_,_,_ := iostreams.Test() // why is this called test? is it to be used for the final product?
+	browser := cmdutil.NewBrowser(os.Getenv("BROWSER"), IO.Out, IO.ErrOut)
+	browser.Browse("www.github.com")
+	
+}
diff --git a/pkg/cmd/root/root.go b/pkg/cmd/root/root.go
@@ -2,7 +2,6 @@ package root
 
 import (
 	"net/http"
-	"fmt"
 
 	"github.com/MakeNowJust/heredoc"
 	"github.com/cli/cli/api"
@@ -95,8 +94,7 @@ func NewCmdRoot(f *cmdutil.Factory, version, buildDate string) *cobra.Command {
 	repoResolvingCmdFactory := *f
 	repoResolvingCmdFactory.BaseRepo = resolvedBaseRepo(f)
 
-	fmt.Println("making browse command");
-	cmd.AddCommand(browseCmd.NewCmdBrowse(f))
+	cmd.AddCommand(browseCmd.NewCmdBrowse(f)) // adds to the commands Commands()
 	cmd.AddCommand(prCmd.NewCmdPR(&repoResolvingCmdFactory))
 	cmd.AddCommand(issueCmd.NewCmdIssue(&repoResolvingCmdFactory))
 	cmd.AddCommand(releaseCmd.NewCmdRelease(&repoResolvingCmdFactory))

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ const (`
`45`	`45`	`func main() {`
`46`	`46`	`code := mainRun()`
`47`	`47`	`os.Exit(int(code))`
	`48`	`+`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`func mainRun() exitCode {`