Fix release download

mislav · mislav · commit 662f83fcb916 · 2020-09-14T15:31:31.000+02:00
Only ever try to set an `Authorization` request header to hosts that we
have OAuth credentials for; skip the header otherwise.
diff --git a/pkg/cmd/factory/http.go b/pkg/cmd/factory/http.go
@@ -24,7 +24,7 @@ func NewHTTPClient(io *iostreams.IOStreams, cfg config.Config, appVersion string
 		api.AddHeader("User-Agent", fmt.Sprintf("GitHub CLI %s", appVersion)),
 		api.AddHeaderFunc("Authorization", func(req *http.Request) (string, error) {
 			hostname := ghinstance.NormalizeHostname(req.URL.Hostname())
-			if token, err := cfg.Get(hostname, "oauth_token"); err == nil || token != "" {
+			if token, err := cfg.Get(hostname, "oauth_token"); err == nil && token != "" {
 				return fmt.Sprintf("token %s", token), nil
 			}
 			return "", nil

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ func NewHTTPClient(io *iostreams.IOStreams, cfg config.Config, appVersion string`
`24`	`24`	`api.AddHeader("User-Agent", fmt.Sprintf("GitHub CLI %s", appVersion)),`
`25`	`25`	`api.AddHeaderFunc("Authorization", func(req *http.Request) (string, error) {`
`26`	`26`	`hostname := ghinstance.NormalizeHostname(req.URL.Hostname())`
`27`		`- if token, err := cfg.Get(hostname, "oauth_token"); err == nil \|\| token != "" {`
	`27`	`+ if token, err := cfg.Get(hostname, "oauth_token"); err == nil && token != "" {`
`28`	`28`	`return fmt.Sprintf("token %s", token), nil`
`29`	`29`	`}`
`30`	`30`	`return "", nil`