Silence stderr in git push during pr create but show it on failures

mislav · mislav · commit 5d644d246898 · 2019-12-04T16:16:10.000+01:00
diff --git a/command/pr_create.go b/command/pr_create.go
@@ -40,7 +40,7 @@ func prCreate(cmd *cobra.Command, _ []string) error {
 	}
 
 	if err = git.Push(remote, fmt.Sprintf("HEAD:%s", head)); err != nil {
-		return fmt.Errorf("was not able to push to remote '%s': %s", remote, err)
+		return err
 	}
 
 	title, err := cmd.Flags().GetString("title")
diff --git a/git/git.go b/git/git.go
@@ -109,8 +109,8 @@ func UncommittedChangeCount() (int, error) {
 }
 
 func Push(remote string, ref string) error {
-	cmd := GitCommand("push", "--set-upstream", remote, ref)
-	return cmd.Run()
+	pushCmd := GitCommand("push", "--set-upstream", remote, ref)
+	return utils.PrepareCmd(pushCmd).Run()
 }
 
 type BranchConfig struct {

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func prCreate(cmd *cobra.Command, _ []string) error {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`if err = git.Push(remote, fmt.Sprintf("HEAD:%s", head)); err != nil {`
`43`		`- return fmt.Errorf("was not able to push to remote '%s': %s", remote, err)`
	`43`	`+ return err`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`title, err := cmd.Flags().GetString("title")`
Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,8 @@ func UncommittedChangeCount() (int, error) {`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`func Push(remote string, ref string) error {`
`112`		`- cmd := GitCommand("push", "--set-upstream", remote, ref)`
`113`		`- return cmd.Run()`
	`112`	`+ pushCmd := GitCommand("push", "--set-upstream", remote, ref)`
	`113`	`+ return utils.PrepareCmd(pushCmd).Run()`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`type BranchConfig struct {`