todo

vilmibm · vilmibm · commit 52a02a7a4bd6 · 2020-06-02T11:26:44.000-05:00
diff --git a/command/alias.go b/command/alias.go
@@ -11,7 +11,7 @@ import (
 
 // TODO
 // - [ ] DEBUG support
-// - [ ] blank aliases stanza
+// - [x] blank aliases stanza
 // - [x] give our commands precedence
 // - [x] prevent overriding existing gh command
 // - [x] allow overwriting alias
diff --git a/internal/config/alias_config.go b/internal/config/alias_config.go
@@ -29,7 +29,8 @@ func (a *AliasConfig) Get(alias string) string {
 
 func (a *AliasConfig) Add(alias, expansion string) error {
 	if a.Root == nil {
-		// TODO awful hack bad type conversion i'm sorry
+		// TODO awful hack bad type conversion i'm sorry. this is to support an empty aliases key and
+		// ought to be generalized into ConfigMap or fileConfig (via Config interface) itself.
 		entry, err := a.Parent.(*fileConfig).FindEntry("aliases")
 
 		var notFound *NotFoundError
