Add buffer to channels to avoid goroutine leak

josebalius · josebalius · commit 4e0ac15fe045 · 2021-09-22T15:10:47.000-04:00
diff --git a/cmd/ghcs/create.go b/cmd/ghcs/create.go
@@ -172,7 +172,7 @@ type getUserResult struct {
 
 // getUser fetches the user record associated with the GITHUB_TOKEN
 func getUser(ctx context.Context, apiClient *api.API) <-chan getUserResult {
-	ch := make(chan getUserResult)
+	ch := make(chan getUserResult, 1)
 	go func() {
 		user, err := apiClient.GetUser(ctx)
 		ch <- getUserResult{user, err}
@@ -187,7 +187,7 @@ type locationResult struct {
 
 // getLocation fetches the closest Codespace datacenter region/location to the user.
 func getLocation(ctx context.Context, apiClient *api.API) <-chan locationResult {
-	ch := make(chan locationResult)
+	ch := make(chan locationResult, 1)
 	go func() {
 		location, err := apiClient.GetCodespaceRegionLocation(ctx)
 		ch <- locationResult{location, err}
diff --git a/cmd/ghcs/ports.go b/cmd/ghcs/ports.go
@@ -123,7 +123,7 @@ type portAttribute struct {
 }
 
 func getDevContainer(ctx context.Context, apiClient *api.API, codespace *api.Codespace) <-chan devContainerResult {
-	ch := make(chan devContainerResult)
+	ch := make(chan devContainerResult, 1)
 	go func() {
 		contents, err := apiClient.GetCodespaceRepositoryContents(ctx, codespace, ".devcontainer/devcontainer.json")
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ type portAttribute struct {`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`func getDevContainer(ctx context.Context, apiClient api.API, codespace api.Codespace) <-chan devContainerResult {`
`126`		`- ch := make(chan devContainerResult)`
	`126`	`+ ch := make(chan devContainerResult, 1)`
`127`	`127`	`go func() {`
`128`	`128`	`contents, err := apiClient.GetCodespaceRepositoryContents(ctx, codespace, ".devcontainer/devcontainer.json")`
`129`	`129`	`if err != nil {`