Merge pull request cli#2234 from XD-DENG/stringsbuilder

mislav · web-flow · commit 4b395c5dd2a6 · 2020-10-21T18:22:43.000+02:00
Use strings.Builder for more efficient string concatenation
diff --git a/pkg/cmd/pr/create/create.go b/pkg/cmd/pr/create/create.go
@@ -502,11 +502,11 @@ func computeDefaults(baseRef, headRef string) (shared.Defaults, error) {
 	} else {
 		out.Title = utils.Humanize(headRef)
 
-		body := ""
+		var body strings.Builder
 		for i := len(commits) - 1; i >= 0; i-- {
-			body += fmt.Sprintf("- %s\n", commits[i].Title)
+			fmt.Fprintf(&body, "- %s\n", commits[i].Title)
 		}
-		out.Body = body
+		out.Body = body.String()
 	}
 
 	return out, nil

Original file line number	Diff line number	Diff line change
`@@ -502,11 +502,11 @@ func computeDefaults(baseRef, headRef string) (shared.Defaults, error) {`
`502`	`502`	`} else {`
`503`	`503`	`out.Title = utils.Humanize(headRef)`
`504`	`504`
`505`		`- body := ""`
	`505`	`+ var body strings.Builder`
`506`	`506`	`for i := len(commits) - 1; i >= 0; i-- {`
`507`		`- body += fmt.Sprintf("- %s\n", commits[i].Title)`
	`507`	`+ fmt.Fprintf(&body, "- %s\n", commits[i].Title)`
`508`	`508`	`}`
`509`		`- out.Body = body`
	`509`	`+ out.Body = body.String()`
`510`	`510`	`}`
`511`	`511`
`512`	`512`	`return out, nil`