Ensure that tests for command factory never read from user's config

mislav · mislav · commit 4b2cded1f86e · 2021-06-17T17:59:34.000+02:00
If these tests are going to exerise `factory.New()`, the config getter
should always be overriden since the default config getter reads from
`~/.config/gh` and thus makes tests dependent on the user's environment.
diff --git a/pkg/cmd/factory/default_test.go b/pkg/cmd/factory/default_test.go
@@ -333,8 +333,10 @@ func Test_ioStreams_pager(t *testing.T) {
 				}
 			}
 			f := New("1")
-			if tt.config != nil {
-				f.Config = func() (config.Config, error) {
+			f.Config = func() (config.Config, error) {
+				if tt.config == nil {
+					return config.NewBlankConfig(), nil
+				} else {
 					return tt.config, nil
 				}
 			}
@@ -363,8 +365,10 @@ func Test_ioStreams_prompt(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			f := New("1")
-			if tt.config != nil {
-				f.Config = func() (config.Config, error) {
+			f.Config = func() (config.Config, error) {
+				if tt.config == nil {
+					return config.NewBlankConfig(), nil
+				} else {
 					return tt.config, nil
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -333,8 +333,10 @@ func Test_ioStreams_pager(t *testing.T) {`
`333`	`333`	`}`
`334`	`334`	`}`
`335`	`335`	`f := New("1")`
`336`		`- if tt.config != nil {`
`337`		`- f.Config = func() (config.Config, error) {`
	`336`	`+ f.Config = func() (config.Config, error) {`
	`337`	`+ if tt.config == nil {`
	`338`	`+ return config.NewBlankConfig(), nil`
	`339`	`+ } else {`
`338`	`340`	`return tt.config, nil`
`339`	`341`	`}`
`340`	`342`	`}`
`@@ -363,8 +365,10 @@ func Test_ioStreams_prompt(t *testing.T) {`
`363`	`365`	`for _, tt := range tests {`
`364`	`366`	`t.Run(tt.name, func(t *testing.T) {`
`365`	`367`	`f := New("1")`
`366`		`- if tt.config != nil {`
`367`		`- f.Config = func() (config.Config, error) {`
	`368`	`+ f.Config = func() (config.Config, error) {`
	`369`	`+ if tt.config == nil {`
	`370`	`+ return config.NewBlankConfig(), nil`
	`371`	`+ } else {`
`368`	`372`	`return tt.config, nil`
`369`	`373`	`}`
`370`	`374`	`}`