Ensure descriptive error when no github.com remotes found

mislav · mislav · commit 4727fc465982 · 2020-02-20T22:30:25.000+01:00
diff --git a/context/context.go b/context/context.go
@@ -201,13 +201,17 @@ func (c *fsContext) Remotes() (Remotes, error) {
 		if err != nil {
 			return nil, err
 		}
-
 		if len(gitRemotes) == 0 {
-			return nil, errors.New("No git remotes found")
+			return nil, errors.New("no git remotes found")
 		}
+
 		sshTranslate := git.ParseSSHConfig().Translator()
 		c.remotes = translateRemotes(gitRemotes, sshTranslate)
 	}
+
+	if len(c.remotes) == 0 {
+		return nil, errors.New("no git remote found for a github.com repository")
+	}
 	return c.remotes, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -201,13 +201,17 @@ func (c *fsContext) Remotes() (Remotes, error) {`
`201`	`201`	`if err != nil {`
`202`	`202`	`return nil, err`
`203`	`203`	`}`
`204`		`-`
`205`	`204`	`if len(gitRemotes) == 0 {`
`206`		`- return nil, errors.New("No git remotes found")`
	`205`	`+ return nil, errors.New("no git remotes found")`
`207`	`206`	`}`
	`207`	`+`
`208`	`208`	`sshTranslate := git.ParseSSHConfig().Translator()`
`209`	`209`	`c.remotes = translateRemotes(gitRemotes, sshTranslate)`
`210`	`210`	`}`
	`211`	`+`
	`212`	`+ if len(c.remotes) == 0 {`
	`213`	`+ return nil, errors.New("no git remote found for a github.com repository")`
	`214`	`+ }`
`211`	`215`	`return c.remotes, nil`
`212`	`216`	`}`
`213`	`217`