Merge pull request cli#723 from cli/go-ci-checks

Nate Smith · web-flow · commit 44a37cbba339 · 2020-04-01T10:58:14.000-05:00
Assert that running `go fmt` or `go mod tidy` produces no changes in CI
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -18,10 +18,29 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Verify dependencies
-        run: go mod verify
+        shell: bash
+        run: |
+          go mod verify
+          go mod download
 
-      - name: Build
+      - name: Run tests
         shell: bash
         run: |
-          go test -race ./...
-          go build -v ./cmd/gh
+          assert-nothing-changed() {
+            local diff
+            git checkout -- .
+            "$@" >/dev/null || true
+            if ! diff="$(git diff -U1 --color --exit-code)"; then
+              printf '\n\e[31mError: running `\e[1m%s\e[22m` results in modifications that you must check into version control:\e[0m\n%s\n' "$*" "$diff" >&2
+              return 1
+            fi
+          }
+
+          STATUS=0
+          go test -race ./... || STATUS=$?
+          assert-nothing-changed go fmt ./... || STATUS=$?
+          assert-nothing-changed go mod tidy || STATUS=$?
+          exit $STATUS
+
+      - name: Build
+        run: go build -v ./cmd/gh
