Merge pull request cli#5276 from markphelps/codespaces-accept-perms-wording

Mark Phelps · web-flow · commit 43e4e9514d77 · 2022-03-15T12:55:44.000-04:00
diff --git a/pkg/cmd/codespace/create.go b/pkg/cmd/codespace/create.go
@@ -173,7 +173,7 @@ func (a *App) handleAdditionalPermissions(ctx context.Context, createParams *api
 	}
 
 	choices := []string{
-		"Continue in browser to review and authorize additional permissions",
+		"Continue in browser to review and authorize additional permissions (Recommended)",
 		"Continue without authorizing additional permissions",
 	}
 
@@ -199,6 +199,7 @@ func (a *App) handleAdditionalPermissions(ctx context.Context, createParams *api
 
 	// if the user chose to continue in the browser, open the URL
 	if answers.Accept == choices[0] {
+		fmt.Fprintln(a.io.ErrOut, "Please re-run the create request after accepting permissions in the browser.")
 		if err := a.browser.Browse(allowPermissionsURL); err != nil {
 			return nil, fmt.Errorf("error opening browser: %w", err)
 		}

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ func (a App) handleAdditionalPermissions(ctx context.Context, createParams api`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`choices := []string{`
`176`		`- "Continue in browser to review and authorize additional permissions",`
	`176`	`+ "Continue in browser to review and authorize additional permissions (Recommended)",`
`177`	`177`	`"Continue without authorizing additional permissions",`
`178`	`178`	`}`
`179`	`179`
`@@ -199,6 +199,7 @@ func (a App) handleAdditionalPermissions(ctx context.Context, createParams api`
`199`	`199`
`200`	`200`	`// if the user chose to continue in the browser, open the URL`
`201`	`201`	`if answers.Accept == choices[0] {`
	`202`	`+ fmt.Fprintln(a.io.ErrOut, "Please re-run the create request after accepting permissions in the browser.")`
`202`	`203`	`if err := a.browser.Browse(allowPermissionsURL); err != nil {`
`203`	`204`	`return nil, fmt.Errorf("error opening browser: %w", err)`
`204`	`205`	`}`