Un-publish Hosts from the Config interface

mislav · mislav · commit 43a8b311bc4d · 2020-06-02T13:19:21.000+02:00
It's not being depended on anywhere right now, so this minimizes the
public interface.
diff --git a/internal/config/config_type.go b/internal/config/config_type.go
@@ -12,7 +12,6 @@ const defaultGitProtocol = "https"
 
 // This interface describes interacting with some persistent configuration for gh.
 type Config interface {
-	Hosts() ([]*HostConfig, error)
 	Get(string, string) (string, error)
 	Set(string, string, string) error
 	Write() error
@@ -145,7 +144,7 @@ func (c *fileConfig) Set(hostname, key, value string) error {
 }
 
 func (c *fileConfig) configForHost(hostname string) (*HostConfig, error) {
-	hosts, err := c.Hosts()
+	hosts, err := c.hostEntries()
 	if err != nil {
 		return nil, fmt.Errorf("failed to parse hosts config: %w", err)
 	}
@@ -167,7 +166,7 @@ func (c *fileConfig) Write() error {
 	return WriteConfigFile(ConfigFile(), marshalled)
 }
 
-func (c *fileConfig) Hosts() ([]*HostConfig, error) {
+func (c *fileConfig) hostEntries() ([]*HostConfig, error) {
 	if len(c.hosts) > 0 {
 		return c.hosts, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@ const defaultGitProtocol = "https"`
`12`	`12`
`13`	`13`	`// This interface describes interacting with some persistent configuration for gh.`
`14`	`14`	`type Config interface {`
`15`		`- Hosts() ([]*HostConfig, error)`
`16`	`15`	`Get(string, string) (string, error)`
`17`	`16`	`Set(string, string, string) error`
`18`	`17`	`Write() error`
`@@ -145,7 +144,7 @@ func (c *fileConfig) Set(hostname, key, value string) error {`
`145`	`144`	`}`
`146`	`145`
`147`	`146`	`func (c fileConfig) configForHost(hostname string) (HostConfig, error) {`
`148`		`- hosts, err := c.Hosts()`
	`147`	`+ hosts, err := c.hostEntries()`
`149`	`148`	`if err != nil {`
`150`	`149`	`return nil, fmt.Errorf("failed to parse hosts config: %w", err)`
`151`	`150`	`}`
`@@ -167,7 +166,7 @@ func (c *fileConfig) Write() error {`
`167`	`166`	`return WriteConfigFile(ConfigFile(), marshalled)`
`168`	`167`	`}`
`169`	`168`
`170`		`-func (c fileConfig) Hosts() ([]HostConfig, error) {`
	`169`	`+func (c fileConfig) hostEntries() ([]HostConfig, error) {`
`171`	`170`	`if len(c.hosts) > 0 {`
`172`	`171`	`return c.hosts, nil`
`173`	`172`	`}`