fix tests

vilmibm · vilmibm · commit 425f707c7d7d · 2020-09-15T13:36:32.000-05:00
diff --git a/pkg/cmd/gist/list/http.go b/pkg/cmd/gist/list/http.go
@@ -26,9 +26,6 @@ func listGists(client *http.Client, hostname string, limit int, visibility strin
 		return nil, err
 	}
 
-	// TODO in tests the api call is matching properly and encoding json properly but i'm getting no
-	// result and no parse error, wtf?
-
 	gists := []shared.Gist{}
 
 	for _, gist := range result {
diff --git a/pkg/cmd/gist/list/list_test.go b/pkg/cmd/gist/list/list_test.go
@@ -88,14 +88,13 @@ func TestNewCmdList(t *testing.T) {
 	}
 }
 
-// TODO execution tests
-
 func Test_listRun(t *testing.T) {
 	tests := []struct {
 		name    string
 		opts    *ListOptions
 		wantOut string
 		stubs   func(*httpmock.Registry)
+		nontty  bool
 	}{
 		{
 			name: "no gists",
@@ -116,6 +115,7 @@ func Test_listRun(t *testing.T) {
 		// TODO public filter
 		// TODO secret filter
 		// TODO limit specified
+		// TODO nontty output
 	}
 
 	for _, tt := range tests {
@@ -149,8 +149,16 @@ func Test_listRun(t *testing.T) {
 		}
 
 		io, _, stdout, _ := iostreams.Test()
+		io.SetStdoutTTY(!tt.nontty)
 		tt.opts.IO = io
 
+		if tt.opts.Limit == 0 {
+			tt.opts.Limit = 10
+		}
+
+		if tt.opts.Visibility == "" {
+			tt.opts.Visibility = "all"
+		}
 		t.Run(tt.name, func(t *testing.T) {
 			err := listRun(tt.opts)
 			assert.NoError(t, err)
diff --git a/pkg/httpmock/stub.go b/pkg/httpmock/stub.go
@@ -3,7 +3,6 @@ package httpmock
 import (
 	"bytes"
 	"encoding/json"
-	"fmt"
 	"io"
 	"io/ioutil"
 	"net/http"
@@ -87,8 +86,6 @@ func StatusStringResponse(status int, body string) Responder {
 func JSONResponse(body interface{}) Responder {
 	return func(req *http.Request) (*http.Response, error) {
 		b, _ := json.Marshal(body)
-		fmt.Printf("DEBUG %#v\n", "COOOOOL")
-		fmt.Printf("DEBUG %#v\n", string(b))
 		return httpResponse(200, req, bytes.NewBuffer(b)), nil
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,6 @@ func listGists(client *http.Client, hostname string, limit int, visibility strin`
`26`	`26`	`return nil, err`
`27`	`27`	`}`
`28`	`28`
`29`		`- // TODO in tests the api call is matching properly and encoding json properly but i'm getting no`
`30`		`- // result and no parse error, wtf?`
`31`		`-`
`32`	`29`	`gists := []shared.Gist{}`
`33`	`30`
`34`	`31`	`for _, gist := range result {`