Add the release view --web flag

mislav · mislav · commit 3d58fa785fc7 · 2020-09-09T17:01:29.000+02:00
diff --git a/pkg/cmd/release/view/view.go b/pkg/cmd/release/view/view.go
@@ -22,6 +22,7 @@ type ViewOptions struct {
 	BaseRepo   func() (ghrepo.Interface, error)
 
 	TagName string
+	WebMode bool
 }
 
 func NewCmdView(f *cmdutil.Factory, runF func(*ViewOptions) error) *cobra.Command {
@@ -55,6 +56,8 @@ func NewCmdView(f *cmdutil.Factory, runF func(*ViewOptions) error) *cobra.Comman
 		},
 	}
 
+	cmd.Flags().BoolVarP(&opts.WebMode, "web", "w", false, "Open the release in the browser")
+
 	return cmd
 }
 
@@ -83,6 +86,13 @@ func viewRun(opts *ViewOptions) error {
 		}
 	}
 
+	if opts.WebMode {
+		if opts.IO.IsStdoutTTY() {
+			fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", utils.DisplayURL(release.HTMLURL))
+		}
+		return utils.OpenInBrowser(release.HTMLURL)
+	}
+
 	if opts.IO.IsStdoutTTY() {
 		if err := renderReleaseTTY(opts.IO, release); err != nil {
 			return err
diff --git a/pkg/cmd/release/view/view_test.go b/pkg/cmd/release/view/view_test.go
@@ -32,6 +32,7 @@ func Test_NewCmdView(t *testing.T) {
 			isTTY: true,
 			want: ViewOptions{
 				TagName: "v1.2.3",
+				WebMode: false,
 			},
 		},
 		{
@@ -40,6 +41,16 @@ func Test_NewCmdView(t *testing.T) {
 			isTTY: true,
 			want: ViewOptions{
 				TagName: "",
+				WebMode: false,
+			},
+		},
+		{
+			name:  "web mode",
+			args:  "-w",
+			isTTY: true,
+			want: ViewOptions{
+				TagName: "",
+				WebMode: true,
 			},
 		},
 	}
@@ -78,6 +89,7 @@ func Test_NewCmdView(t *testing.T) {
 			}
 
 			assert.Equal(t, tt.want.TagName, opts.TagName)
+			assert.Equal(t, tt.want.WebMode, opts.WebMode)
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ type ViewOptions struct {`
`22`	`22`	`BaseRepo func() (ghrepo.Interface, error)`
`23`	`23`
`24`	`24`	`TagName string`
	`25`	`+ WebMode bool`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`func NewCmdView(f cmdutil.Factory, runF func(ViewOptions) error) *cobra.Command {`
`@@ -55,6 +56,8 @@ func NewCmdView(f cmdutil.Factory, runF func(ViewOptions) error) *cobra.Comman`
`55`	`56`	`},`
`56`	`57`	`}`
`57`	`58`
	`59`	`+ cmd.Flags().BoolVarP(&opts.WebMode, "web", "w", false, "Open the release in the browser")`
	`60`	`+`
`58`	`61`	`return cmd`
`59`	`62`	`}`
`60`	`63`
`@@ -83,6 +86,13 @@ func viewRun(opts *ViewOptions) error {`
`83`	`86`	`}`
`84`	`87`	`}`
`85`	`88`
	`89`	`+ if opts.WebMode {`
	`90`	`+ if opts.IO.IsStdoutTTY() {`
	`91`	`+ fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", utils.DisplayURL(release.HTMLURL))`
	`92`	`+ }`
	`93`	`+ return utils.OpenInBrowser(release.HTMLURL)`
	`94`	`+ }`
	`95`	`+`
`86`	`96`	`if opts.IO.IsStdoutTTY() {`
`87`	`97`	`if err := renderReleaseTTY(opts.IO, release); err != nil {`
`88`	`98`	`return err`