Merge pull request cli#4189 from cuonglm/issue-4188

mislav · web-flow · commit 355d28195ef1 · 2021-08-24T20:48:46.000+02:00
Disable auth for cobra shell request completion hidden commands
diff --git a/pkg/cmdutil/auth_check.go b/pkg/cmdutil/auth_check.go
@@ -34,9 +34,11 @@ func CheckAuth(cfg config.Config) bool {
 }
 
 func IsAuthCheckEnabled(cmd *cobra.Command) bool {
-	if cmd.Name() == "help" {
+	switch cmd.Name() {
+	case "help", cobra.ShellCompRequestCmd, cobra.ShellCompNoDescRequestCmd:
 		return false
 	}
+
 	for c := cmd; c.Parent() != nil; c = c.Parent() {
 		if c.Annotations != nil && c.Annotations["skipAuthCheck"] == "true" {
 			return false

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,11 @@ func CheckAuth(cfg config.Config) bool {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`func IsAuthCheckEnabled(cmd *cobra.Command) bool {`
`37`		`- if cmd.Name() == "help" {`
	`37`	`+ switch cmd.Name() {`
	`38`	`+ case "help", cobra.ShellCompRequestCmd, cobra.ShellCompNoDescRequestCmd:`
`38`	`39`	`return false`
`39`	`40`	`}`
	`41`	`+`
`40`	`42`	`for c := cmd; c.Parent() != nil; c = c.Parent() {`
`41`	`43`	`if c.Annotations != nil && c.Annotations["skipAuthCheck"] == "true" {`
`42`	`44`	`return false`