add comment for improvements

josebalius · josebalius · commit 2cc91c224edc · 2021-08-27T12:53:27.000-04:00
diff --git a/internal/codespaces/codespaces.go b/internal/codespaces/codespaces.go
@@ -62,6 +62,7 @@ type logger interface {
 	Println(v ...interface{}) (int, error)
 }
 
+// TODO(josebalius): we should move some of this to the liveshare.Connection struct
 func connectionReady(codespace *api.Codespace) bool {
 	ready := codespace.Environment.Connection.SessionID != ""
 	ready = ready && codespace.Environment.Connection.SessionToken != ""

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ type logger interface {`
`62`	`62`	`Println(v ...interface{}) (int, error)`
`63`	`63`	`}`
`64`	`64`
	`65`	`+// TODO(josebalius): we should move some of this to the liveshare.Connection struct`
`65`	`66`	`func connectionReady(codespace *api.Codespace) bool {`
`66`	`67`	`ready := codespace.Environment.Connection.SessionID != ""`
`67`	`68`	`ready = ready && codespace.Environment.Connection.SessionToken != ""`