Return error if it's an invalid URL

cristiand391 · cristiand391 · commit 2af136cc780c · 2020-09-19T18:48:00.000-03:00
diff --git a/pkg/cmd/gist/view/view.go b/pkg/cmd/gist/view/view.go
@@ -71,10 +71,16 @@ func viewRun(opts *ViewOptions) error {
 		return utils.OpenInBrowser(gistURL)
 	}
 
-	u, err := url.Parse(opts.Selector)
-	if err == nil {
-		if strings.HasPrefix(u.Path, "/") {
-			gistID = strings.Split(u.Path, "/")[2]
+	if strings.Contains(gistID, "/") {
+		u, err := url.Parse(opts.Selector)
+		if err == nil && strings.HasPrefix(u.Path, "/") {
+			split := strings.Split(u.Path, "/")
+
+			if len(split) > 2 && split[2] != "" {
+				gistID = strings.Split(u.Path, "/")[2]
+			} else {
+				return fmt.Errorf("Invalid gist URL %s", u)
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -71,10 +71,16 @@ func viewRun(opts *ViewOptions) error {`
`71`	`71`	`return utils.OpenInBrowser(gistURL)`
`72`	`72`	`}`
`73`	`73`
`74`		`- u, err := url.Parse(opts.Selector)`
`75`		`- if err == nil {`
`76`		`- if strings.HasPrefix(u.Path, "/") {`
`77`		`- gistID = strings.Split(u.Path, "/")[2]`
	`74`	`+ if strings.Contains(gistID, "/") {`
	`75`	`+ u, err := url.Parse(opts.Selector)`
	`76`	`+ if err == nil && strings.HasPrefix(u.Path, "/") {`
	`77`	`+ split := strings.Split(u.Path, "/")`
	`78`	`+`
	`79`	`+ if len(split) > 2 && split[2] != "" {`
	`80`	`+ gistID = strings.Split(u.Path, "/")[2]`
	`81`	`+ } else {`
	`82`	`+ return fmt.Errorf("Invalid gist URL %s", u)`
	`83`	`+ }`
`78`	`84`	`}`
`79`	`85`	`}`
`80`	`86`