Merge pull request cli#1828 from y-yagi/do-not-send-requests-when-unnecessary

Nate Smith · web-flow · commit 2a9b5de8c0bb · 2020-09-21T16:40:41.000-05:00
Don't send a request when the contents haven't changed
diff --git a/pkg/cmd/gist/edit/edit.go b/pkg/cmd/gist/edit/edit.go
@@ -174,6 +174,10 @@ func editRun(opts *EditOptions) error {
 		}
 	}
 
+	if len(filesToUpdate) == 0 {
+		return nil
+	}
+
 	err = updateGist(client, ghinstance.OverridableDefault(), gist)
 	if err != nil {
 		return err
diff --git a/pkg/cmd/gist/edit/edit_test.go b/pkg/cmd/gist/edit/edit_test.go
@@ -177,6 +177,19 @@ func Test_editRun(t *testing.T) {
 				},
 			},
 		},
+		{
+			name: "not change",
+			gist: &shared.Gist{
+				ID: "1234",
+				Files: map[string]*shared.GistFile{
+					"cicada.txt": {
+						Filename: "cicada.txt",
+						Content:  "new file content",
+						Type:     "text/plain",
+					},
+				},
+			},
+		},
 	}
 
 	for _, tt := range tests {

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,10 @@ func editRun(opts *EditOptions) error {`
`174`	`174`	`}`
`175`	`175`	`}`
`176`	`176`
	`177`	`+ if len(filesToUpdate) == 0 {`
	`178`	`+ return nil`
	`179`	`+ }`
	`180`	`+`
`177`	`181`	`err = updateGist(client, ghinstance.OverridableDefault(), gist)`
`178`	`182`	`if err != nil {`
`179`	`183`	`return err`