always pass a non-nil logger to openSSHSession

znull · znull · commit 28dd73ffdf1d · 2021-12-20T13:57:53.000-07:00
diff --git a/pkg/cmd/codespace/ssh.go b/pkg/cmd/codespace/ssh.go
@@ -219,7 +219,7 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions, execut
 				}
 			}()
 
-			session, err := a.openSSHSession(ctx, cs, nil)
+			session, err := a.openSSHSession(ctx, cs, noopLogger())
 			if err != nil {
 				result.err = fmt.Errorf("error connecting to codespace: %w", err)
 				return
@@ -299,10 +299,6 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions, execut
 }
 
 func (a *App) openSSHSession(ctx context.Context, codespace *api.Codespace, liveshareLogger *log.Logger) (*liveshare.Session, error) {
-	if liveshareLogger == nil {
-		liveshareLogger = noopLogger()
-	}
-
 	session, err := codespaces.ConnectToLiveshare(ctx, a, liveshareLogger, a.apiClient, codespace)
 	if err != nil {
 		return nil, fmt.Errorf("error connecting to codespace: %w", err)
