Skip to content

Commit 2328dff

Browse files
Add test
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
1 parent fabbfe1 commit 2328dff

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

command/pr.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ func prMerge(cmd *cobra.Command, args []string) error {
531531
if err != nil {
532532
return err
533533
}
534-
fmt.Fprintf(colorableOut(cmd), "%s Deleted branch %s\n", utils.Red("✔"), utils.Cyan(branch))
534+
fmt.Fprintf(colorableOut(cmd), "%s Deleted local branch %s\n", utils.Red("✔"), utils.Cyan(branch))
535535
}
536536

537537
return nil

command/pr_test.go

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,35 +1095,39 @@ func TestPrMerge_alreadyMerged(t *testing.T) {
10951095
}
10961096

10971097
func TestPRMerge_interactive(t *testing.T) {
1098-
initWithStubs("feature",
1098+
initWithStubs("blueberries",
10991099
stubResponse{200, bytes.NewBufferString(`
1100-
{ "data": {
1101-
1102-
} }`)})
1100+
{ "data": { "repository": { "pullRequests": { "nodes": [
1101+
{ "headRefName": "blueberries", "id": "THE-ID", "number": 3}
1102+
] } } } }`)},
1103+
stubResponse{200, bytes.NewBufferString(`{ "data": {} }`)})
11031104

11041105
cs, cmdTeardown := test.InitCmdStubber()
11051106
defer cmdTeardown()
11061107

1108+
cs.Stub("")
1109+
cs.Stub("")
1110+
cs.Stub("")
11071111
cs.Stub("")
11081112

11091113
as, surveyTeardown := initAskStubber()
11101114
defer surveyTeardown()
11111115

11121116
as.Stub([]*QuestionStub{
11131117
{
1114-
Name: "choose merge method",
1115-
Value: "merge",
1118+
Name: "mergeMethod",
1119+
Value: 0,
11161120
},
11171121
{
1118-
Name: "delete branch locally",
1119-
Default: true,
1120-
Value: "Y",
1122+
Name: "deleteBranch",
1123+
Value: true,
11211124
},
11221125
})
11231126

11241127
output, err := RunCommand(`pr merge`)
1125-
eq(t, err, nil)
1128+
if err != nil {
1129+
t.Fatalf("Got unexpected error running `pr merge` %s", err)
1130+
}
11261131

1127-
stderr := string(output.Stderr())
1128-
eq(t, strings.Contains(stderr, "warning: could not compute title or body defaults: could not find any commits"), true)
1132+
test.ExpectLines(t, output.String(), "Merged pull request #3", "Deleted local branch")
11291133
}

0 commit comments

Comments
 (0)