print success messages

vilmibm · vilmibm · commit 2248565839cd · 2020-12-09T17:37:13.000-08:00
diff --git a/pkg/cmd/secret/remove/remove.go b/pkg/cmd/secret/remove/remove.go
@@ -89,5 +89,10 @@ func removeRun(opts *RemoveOptions) error {
 		return fmt.Errorf("failed to delete secret %s: %w", opts.SecretName, err)
 	}
 
+	if opts.IO.IsStdoutTTY() {
+		cs := opts.IO.ColorScheme()
+		fmt.Fprintf(opts.IO.Out, "%s Removed secret %s\n", cs.SuccessIcon(), opts.SecretName)
+	}
+
 	return nil
 }
diff --git a/pkg/cmd/secret/secret.go b/pkg/cmd/secret/secret.go
@@ -23,7 +23,6 @@ func NewCmdSecret(f *cmdutil.Factory) *cobra.Command {
 	cmdutil.EnableRepoOverride(cmd, f)
 
 	cmd.AddCommand(cmdList.NewCmdList(f, nil))
-	// TODO add success messages to these:
 	cmd.AddCommand(cmdSet.NewCmdSet(f, nil))
 	cmd.AddCommand(cmdRemove.NewCmdRemove(f, nil))
 
diff --git a/pkg/cmd/secret/set/set.go b/pkg/cmd/secret/set/set.go
@@ -163,6 +163,11 @@ func setRun(opts *SetOptions) error {
 		return fmt.Errorf("failed to set secret: %w", err)
 	}
 
+	if opts.IO.IsStdoutTTY() {
+		cs := opts.IO.ColorScheme()
+		fmt.Fprintf(opts.IO.Out, "%s Set secret %s\n", cs.SuccessIcon(), opts.SecretName)
+	}
+
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -89,5 +89,10 @@ func removeRun(opts *RemoveOptions) error {`
`89`	`89`	`return fmt.Errorf("failed to delete secret %s: %w", opts.SecretName, err)`
`90`	`90`	`}`
`91`	`91`
	`92`	`+ if opts.IO.IsStdoutTTY() {`
	`93`	`+ cs := opts.IO.ColorScheme()`
	`94`	`+ fmt.Fprintf(opts.IO.Out, "%s Removed secret %s\n", cs.SuccessIcon(), opts.SecretName)`
	`95`	`+ }`
	`96`	`+`
`92`	`97`	`return nil`
`93`	`98`	`}`
Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,11 @@ func setRun(opts *SetOptions) error {`
`163`	`163`	`return fmt.Errorf("failed to set secret: %w", err)`
`164`	`164`	`}`
`165`	`165`
	`166`	`+ if opts.IO.IsStdoutTTY() {`
	`167`	`+ cs := opts.IO.ColorScheme()`
	`168`	`+ fmt.Fprintf(opts.IO.Out, "%s Set secret %s\n", cs.SuccessIcon(), opts.SecretName)`
	`169`	`+ }`
	`170`	`+`
`166`	`171`	`return nil`
`167`	`172`	`}`
`168`	`173`