pr bug/rest-204 review feedback

gertd · gertd · commit 203525c031f7 · 2020-04-10T16:48:11.000-07:00
diff --git a/api/client.go b/api/client.go
@@ -146,7 +146,7 @@ func (c Client) REST(method string, p string, body io.Reader, data interface{})
 		return handleHTTPError(resp)
 	}
 
-	if resp.StatusCode == http.StatusNoContent && resp.ContentLength == 0 {
+	if resp.StatusCode == http.StatusNoContent {
 		return nil
 	}
 
diff --git a/api/client_rest_test.go b/api/client_rest_test.go
diff --git a/api/client_test.go b/api/client_test.go
@@ -50,3 +50,17 @@ func TestGraphQLError(t *testing.T) {
 		t.Fatalf("got %q", err.Error())
 	}
 }
+
+func TestRESTGetDelete(t *testing.T) {
+	http := &FakeHTTP{}
+
+	client := NewClient(
+		ReplaceTripper(http),
+	)
+
+	http.StubResponse(204, bytes.NewBuffer([]byte{}))
+
+	r := bytes.NewReader([]byte(`{}`))
+	err := client.REST("DELETE", "applications/CLIENTID/grant", r, nil)
+	eq(t, err, nil)
+}

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ func (c Client) REST(method string, p string, body io.Reader, data interface{})`
`146`	`146`	`return handleHTTPError(resp)`
`147`	`147`	`}`
`148`	`148`
`149`		`- if resp.StatusCode == http.StatusNoContent && resp.ContentLength == 0 {`
	`149`	`+ if resp.StatusCode == http.StatusNoContent {`
`150`	`150`	`return nil`
`151`	`151`	`}`
`152`	`152`