Have FindDraftRelease be truer to its name

mislav · mislav · commit 1ad9b0b14e97 · 2020-09-03T15:35:07.000+02:00
diff --git a/pkg/cmd/release/shared/fetch.go b/pkg/cmd/release/shared/fetch.go
@@ -113,7 +113,7 @@ func FetchLatestRelease(httpClient *http.Client, baseRepo ghrepo.Interface) (*Re
 	return &release, nil
 }
 
-// FindDraftRelease interates over all releases in a repository until it finds one that matches tagName.
+// FindDraftRelease returns the latest draft release that matches tagName.
 func FindDraftRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagName string) (*Release, error) {
 	path := fmt.Sprintf("repos/%s/%s/releases", baseRepo.RepoOwner(), baseRepo.RepoName())
 	url := ghinstance.RESTPrefix(baseRepo.RepoHost()) + path
@@ -148,7 +148,7 @@ func FindDraftRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagNam
 		}
 
 		for _, r := range releases {
-			if r.TagName == tagName {
+			if r.IsDraft && r.TagName == tagName {
 				return &r, nil
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ func FetchLatestRelease(httpClient http.Client, baseRepo ghrepo.Interface) (Re`
`113`	`113`	`return &release, nil`
`114`	`114`	`}`
`115`	`115`
`116`		`-// FindDraftRelease interates over all releases in a repository until it finds one that matches tagName.`
	`116`	`+// FindDraftRelease returns the latest draft release that matches tagName.`
`117`	`117`	`func FindDraftRelease(httpClient http.Client, baseRepo ghrepo.Interface, tagName string) (Release, error) {`
`118`	`118`	`path := fmt.Sprintf("repos/%s/%s/releases", baseRepo.RepoOwner(), baseRepo.RepoName())`
`119`	`119`	`url := ghinstance.RESTPrefix(baseRepo.RepoHost()) + path`
`@@ -148,7 +148,7 @@ func FindDraftRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagNam`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`for _, r := range releases {`
`151`		`- if r.TagName == tagName {`
	`151`	`+ if r.IsDraft && r.TagName == tagName {`
`152`	`152`	`return &r, nil`
`153`	`153`	`}`
`154`	`154`	`}`