return SilentError if completed run failed

despreston · despreston · commit 1980cc83b9dc · 2021-07-09T11:54:58.000-04:00
If `gh run watch ${ID} --exit-status` is run and "ID" is the ID of a completed job that failed, return a SilentError. This ensures that the program returns a non-zero code. Fixes cli#3962
diff --git a/pkg/cmd/run/watch/watch.go b/pkg/cmd/run/watch/watch.go
@@ -123,6 +123,9 @@ func watchRun(opts *WatchOptions) error {
 
 	if run.Status == shared.Completed {
 		fmt.Fprintf(out, "Run %s (%s) has already completed with '%s'\n", cs.Bold(run.Name), cs.Cyanf("%d", run.ID), run.Conclusion)
+		if opts.ExitStatus && run.Conclusion != shared.Success {
+			return cmdutil.SilentError
+		}
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,9 @@ func watchRun(opts *WatchOptions) error {`
`123`	`123`
`124`	`124`	`if run.Status == shared.Completed {`
`125`	`125`	`fmt.Fprintf(out, "Run %s (%s) has already completed with '%s'\n", cs.Bold(run.Name), cs.Cyanf("%d", run.ID), run.Conclusion)`
	`126`	`+ if opts.ExitStatus && run.Conclusion != shared.Success {`
	`127`	`+ return cmdutil.SilentError`
	`128`	`+ }`
`126`	`129`	`return nil`
`127`	`130`	`}`
`128`	`131`